Bug 38643 - Web Inspector: Timeline: Confused use case. See screenshot.
Summary: Web Inspector: Timeline: Confused use case. See screenshot.
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (Deprecated) (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Ilya Tikhonovsky
Depends on: 38726
  Show dependency treegraph
Reported: 2010-05-06 07:09 PDT by Ilya Tikhonovsky
Modified: 2010-05-09 14:02 PDT (History)
4 users (show)

See Also:

screenshot (71.31 KB, image/png)
2010-05-06 07:11 PDT, Ilya Tikhonovsky
no flags Details
screenshot. fixed version. (64.90 KB, image/png)
2010-05-06 07:19 PDT, Ilya Tikhonovsky
no flags Details
[patch] initial version. (14.86 KB, patch)
2010-05-06 07:24 PDT, Ilya Tikhonovsky
no flags Details | Formatted Diff | Diff
[patch] Second iteration. (4.58 KB, patch)
2010-05-07 01:02 PDT, Ilya Tikhonovsky
pfeldman: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Ilya Tikhonovsky 2010-05-06 07:09:16 PDT
If some record is not in visible area then it's expand element also is not visible even if it has children in visible area.
Comment 1 Ilya Tikhonovsky 2010-05-06 07:11:15 PDT
Created attachment 55233 [details]
Comment 2 Ilya Tikhonovsky 2010-05-06 07:19:36 PDT
Created attachment 55234 [details]
screenshot. fixed version.
Comment 3 Ilya Tikhonovsky 2010-05-06 07:24:52 PDT
Created attachment 55235 [details]
[patch] initial version.

expandElement code was extracted into separate class.
Inner Function Call event of TimerFire event will be merged into TimerFire even if it isn't the only child.
Comment 4 Pavel Feldman 2010-05-06 23:08:01 PDT
Comment on attachment 55235 [details]
[patch] initial version.

Please split the patch into two: orphan expanders and list expanders. Orphan expanders part looks good to me as is, but the list expanders patch needs a screenshot!
Comment 5 Ilya Tikhonovsky 2010-05-07 01:02:45 PDT
Created attachment 55349 [details]
[patch] Second iteration.

The patch should be landed after https://bugs.webkit.org/show_bug.cgi?id=38726

The idea: If a record from invisible upper gap has children and it's last child is visible then we create ExpandElement for this invisible row.
Comment 6 Eric Seidel (no email) 2010-05-08 23:13:36 PDT
Attachment 55349 [details] was posted by a committer and has review+, assigning to Ilya Tikhonovsky for commit.
Comment 7 Ilya Tikhonovsky 2010-05-09 14:02:09 PDT
Committing to http://svn.webkit.org/repository/webkit/trunk ...
	M	WebCore/ChangeLog
	M	WebCore/inspector/front-end/TimelinePanel.js
Committed r59059