Created attachment 55219 [details] Proposed autotest The method should emit the signal for all types of html code. For now, It seems that the signal is emitted only for a html containing external resources, which is slightly inconsistent.
Tried to reproduce with latest version of webkit trunk and the signal is emitted properly.
Thanks for trying! Hmm, few months ago we had discussion about this bug. Apparently it was received as a feature not an issue. If I remember correctly that was the only way for a browser to set an error / warning page without polluting history. So if it works now, then something may be broken too :( Personally I don't like this kinds of side effects & hacks. I would love to see cleaner API here. Kenneth, is the usecase valid?
> Hmm, few months ago we had discussion about this bug. Apparently it was received as a feature not an issue. If I remember correctly that was the only way for a browser to set an error / warning page without polluting history. So if it works now, then something may be broken too :( setHTML does not affect back/forward history, that is correct. > Personally I don't like this kinds of side effects & hacks. I would love to see cleaner API here. > > Kenneth, is the usecase valid? I am not kenneth, but I guess it is valid :)
ok, since I wasn't aware of the history, I just tried with a simple qt app which uses qwebview and calls setHtml() function of mainFrame. In that app I got the loadFinished signal. So do you have a writeup somewhere of the requirement so that I can understand it better? Thanks.
Kasthuri, can you apply the patch and see if the test is still passing ?
Created attachment 81881 [details] patch to check loadFinished signal The proposed test modification was connecting for the loadFinished signal after calling setHtml() api which resulted in missing the signal for simple html files. Hence the test was failing. Updated the test to check for the loadFinished signal using QSignalSpy.
Comment on attachment 81881 [details] patch to check loadFinished signal ok
Comment on attachment 81881 [details] patch to check loadFinished signal Clearing flags on attachment: 81881 Committed r78192: <http://trac.webkit.org/changeset/78192>
All reviewed patches have been landed. Closing bug.