Bug 38629 – [WTFURL] Add a file URL parser

• Status: RESOLVED
• Resolution: CONFIGURATION CHANGED
• Component: New Bugs

[Adam Barth]

[WTFURL] Add a file URL parser

[Adam Barth]

Created attachment 55210 [details]
Patch

[Adam Barth]

Comment on attachment 55210 [details]
Patch

I've omitted the wtfurl.gyp change for this file because ap found it confusing before.  However, I still believe the library is incrementally buildable after this patch.

[Sam Weinig]

Comment on attachment 55210 [details]
Patch

> +// Copyright 2007, Google Inc. All rights reserved.
> +//
> +// Redistribution and use in source and binary forms, with or without
> +// modification, are permitted provided that the following conditions are
> +// met:
> +//
> +//     * Redistributions of source code must retain the above copyright
> +// notice, this list of conditions and the following disclaimer.
> +//     * Redistributions in binary form must reproduce the above
> +// copyright notice, this list of conditions and the following disclaimer
> +// in the documentation and/or other materials provided with the
> +// distribution.
> +//     * Neither the name of Google Inc. nor the names of its
> +// contributors may be used to endorse or promote products derived from
> +// this software without specific prior written permission.
> +//
> +// THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS
> +// "AS IS" AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT
> +// LIMITED TO, THE IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR
> +// A PARTICULAR PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT
> +// OWNER OR CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL,
> +// SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT
> +// LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE,
> +// DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY
> +// THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT
> +// (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
> +// OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.

We traditionally use c-style comments for these blocks.

> +
> +template<typename CHAR>

We usually use TitleCase for types, not all caps.

> +    static inline bool isWindowsDriveLetter(CHAR ch)
> +    {
> +        return (ch >= 'A' && ch <= 'Z') || (ch >= 'a' && ch <= 'z');

Can this use isASCIIAlpha()?

[Adam Barth]

Comment on attachment 55210 [details]
Patch

Thanks for the review.

> Can this use isASCIIAlpha()?

We'd like to keep the dependences of this library as small as possible.  In particular, we don't want to depend on anything else in WTF so folks can build the URL parser as a standalone library.  This stems from a desire to use the same URL library in Chrome's networking library and in WebKit.

[Anne van Kesteren]

The URL parser includes a file: URL parser.