Bug 38619 - Delete obsolete CanvasNumberArray
Summary: Delete obsolete CanvasNumberArray
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebGL (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Kenneth Russell
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-05-05 17:53 PDT by Kenneth Russell
Modified: 2010-08-12 17:12 PDT (History)
6 users (show)

See Also:


Attachments
Patch (8.90 KB, patch)
2010-08-11 18:59 PDT, Kenneth Russell
levin: review+
kbr: commit-queue-
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Kenneth Russell 2010-05-05 17:53:14 PDT
The CanvasNumberArray class and associated JavaScript bindings are obsolete and should be deleted. Their continued presence makes it difficult to identify which classes need to be changed when making fixes to the WebGL<T>Arrays.
Comment 1 Kenneth Russell 2010-08-11 18:59:50 PDT
Created attachment 64180 [details]
Patch

Deleted unreferenced code. Built WebKit and Chromium to test.
Comment 2 David Levin 2010-08-11 19:37:22 PDT
Comment on attachment 64180 [details]
Patch

Note that you'll likely break Android's build because it looks like Android.mk and a few other Android.*.mk files refer to *CanvasNumberArray*.

If you wish to fix those up as well, it would be nice (but since they have no buildbot and since they add more build files instead of using the gyp files, I won't force the issue).
Comment 3 Kenneth Russell 2010-08-12 16:55:53 PDT
(In reply to comment #2)
> (From update of attachment 64180 [details])
> Note that you'll likely break Android's build because it looks like Android.mk and a few other Android.*.mk files refer to *CanvasNumberArray*.
> 
> If you wish to fix those up as well, it would be nice (but since they have no buildbot and since they add more build files instead of using the gyp files, I won't force the issue).

Thanks for pointing this out. I'll delete these references in the committed version of the patch.
Comment 4 Kenneth Russell 2010-08-12 17:12:46 PDT
Committed r65285: <http://trac.webkit.org/changeset/65285>