Change IndexedDB to use events instead of callbacks
Created attachment 55138 [details] Patch
Created attachment 55143 [details] Patch
I know it's big, but can one of you guys take a look? I'm planning on starting on the JSC bindings tomorrow.
Created attachment 55258 [details] Patch
Now with JSC bindings and support for build systems other than GYP. Please take a look?
+ adam in case he's willing to take a look
Nate kindly said he'd take a look. Note: I've only built this on Chromium and mac Safari. I'll be sure to watch the build bots closely when I actually commit in case I messed something up.
Comment on attachment 55258 [details] Patch Your WebCore/ChangeLog diff is pretty far out of date in terms of the files listed. Plus a couple of nits inline. Besides that, LGTM. > --- a/WebCore/bindings/js/JSEventCustom.cpp > +++ b/WebCore/bindings/js/JSEventCustom.cpp > @@ -38,6 +38,7 @@ > #include "JSCustomEvent.h" > #include "JSCompositionEvent.h" > #include "JSErrorEvent.h" > +#include "JSIDBRequest.h" > #include "JSKeyboardEvent.h" > #include "JSMessageEvent.h" > #include "JSMouseEvent.h" Why is this necessary? > + ASSERT(0); > + return jsUndefined(); > +} Nit (here and in V8IDBRequestCustom.cpp): Any reason not to use ASSERT_NOT_REACHED instead?
Attachment 55258 [details] was posted by a committer and has review+, assigning to Jeremy Orlow for commit.
(In reply to comment #8) > (From update of attachment 55258 [details]) > Your WebCore/ChangeLog diff is pretty far out of date in terms of the files listed. Plus a couple of nits inline. Done. > > Besides that, LGTM. > > > --- a/WebCore/bindings/js/JSEventCustom.cpp > > +++ b/WebCore/bindings/js/JSEventCustom.cpp > > @@ -38,6 +38,7 @@ > > #include "JSCustomEvent.h" > > #include "JSCompositionEvent.h" > > #include "JSErrorEvent.h" > > +#include "JSIDBRequest.h" > > #include "JSKeyboardEvent.h" > > #include "JSMessageEvent.h" > > #include "JSMouseEvent.h" > > Why is this necessary? It isn't anymore. > > + ASSERT(0); > > + return jsUndefined(); > > +} > > Nit (here and in V8IDBRequestCustom.cpp): Any reason not to use ASSERT_NOT_REACHED instead? Oops, changed. Btw, wasn't there one other problem you noticed when we were chatting on chat?
Committed r59068: <http://trac.webkit.org/changeset/59068>
http://trac.webkit.org/changeset/59068 might have broken Qt Linux Release minimal