Bug 38593 - Web Inspector: Line Numbers should be Aligned with the Source Code Line
Summary: Web Inspector: Line Numbers should be Aligned with the Source Code Line
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (Deprecated) (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-05-05 10:32 PDT by Joseph Pecoraro
Modified: 2010-05-05 21:29 PDT (History)
9 users (show)

See Also:


Attachments
[IMAGE] Before - Centered (303.79 KB, image/png)
2010-05-05 10:32 PDT, Joseph Pecoraro
no flags Details
[IMAGE] After - Aligned to Top (325.75 KB, image/png)
2010-05-05 10:33 PDT, Joseph Pecoraro
no flags Details
[PATCH] Set "vertical-align: top" for line numbers (1.27 KB, patch)
2010-05-05 10:38 PDT, Joseph Pecoraro
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Joseph Pecoraro 2010-05-05 10:32:21 PDT
If there is an error bubble in the source code, the line number is currently shown centered. This is confusing if the error bubble is in javascript and the user wants to set a breakpoint.
Comment 1 Joseph Pecoraro 2010-05-05 10:32:52 PDT
Created attachment 55135 [details]
[IMAGE] Before - Centered
Comment 2 Joseph Pecoraro 2010-05-05 10:33:18 PDT
Created attachment 55136 [details]
[IMAGE] After - Aligned to Top
Comment 3 Joseph Pecoraro 2010-05-05 10:38:21 PDT
Created attachment 55137 [details]
[PATCH] Set "vertical-align: top" for line numbers

Do these type of diffs work with commit-queue yet?
Comment 4 WebKit Commit Bot 2010-05-05 21:29:01 PDT
Comment on attachment 55137 [details]
[PATCH] Set "vertical-align: top" for line numbers

Clearing flags on attachment: 55137

Committed r58857: <http://trac.webkit.org/changeset/58857>
Comment 5 WebKit Commit Bot 2010-05-05 21:29:07 PDT
All reviewed patches have been landed.  Closing bug.