Bug 38589 - [chromium] Add quota parameter to WebStorageNamespace::createSessionStorageNamespace
Summary: [chromium] Add quota parameter to WebStorageNamespace::createSessionStorageN...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit API (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Enhancement
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-05-05 08:54 PDT by Hans Wennborg
Modified: 2010-05-05 11:14 PDT (History)
2 users (show)

See Also:


Attachments
Patch (2.71 KB, patch)
2010-05-05 10:13 PDT, Hans Wennborg
no flags Details | Formatted Diff | Diff
Patch (2.71 KB, patch)
2010-05-05 10:23 PDT, Hans Wennborg
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Hans Wennborg 2010-05-05 08:54:45 PDT
Add quota parameter to WebStorageNamespace::createSessionStorageNamespace.

See http://crbug.com/42740.
Comment 1 Hans Wennborg 2010-05-05 10:13:04 PDT
Created attachment 55133 [details]
Patch
Comment 2 Jeremy Orlow 2010-05-05 10:17:54 PDT
Comment on attachment 55133 [details]
Patch

Please fix and upload another patch.  I'll commit queue + that one (so it'll get committed to WebKit).


> diff --git a/WebKit/chromium/ChangeL
>      // If path is empty, data will not persist. You should call delete on the returned
>      // object when you're finished.
>      WEBKIT_API static WebStorageNamespace* createLocalStorageNamespace(const WebString& backingDirectoryPath, unsigned quota);
> -    WEBKIT_API static WebStorageNamespace* createSessionStorageNamespace();
> +

Don't need this newline.

> +    WEBKIT_API static WebStorageNamespace* createSessionStorageNamespace(unsigned quota);
> +

Don't need this new lines.
Comment 3 Hans Wennborg 2010-05-05 10:23:50 PDT
Created attachment 55134 [details]
Patch
Comment 4 Jeremy Orlow 2010-05-05 10:26:38 PDT
Comment on attachment 55134 [details]
Patch

r=me
Comment 5 WebKit Commit Bot 2010-05-05 11:14:35 PDT
Comment on attachment 55134 [details]
Patch

Clearing flags on attachment: 55134

Committed r58828: <http://trac.webkit.org/changeset/58828>
Comment 6 WebKit Commit Bot 2010-05-05 11:14:41 PDT
All reviewed patches have been landed.  Closing bug.