Bug 38567 - Web Inspector: FontView needs Cleanup
Summary: Web Inspector: FontView needs Cleanup
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (Deprecated) (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-05-05 00:17 PDT by Joseph Pecoraro
Modified: 2010-05-05 00:57 PDT (History)
9 users (show)

See Also:


Attachments
[IMAGE] FontView Before (149.17 KB, image/png)
2010-05-05 00:19 PDT, Joseph Pecoraro
no flags Details
[IMAGE] FontView After (172.96 KB, image/png)
2010-05-05 00:19 PDT, Joseph Pecoraro
no flags Details
[PATCH] Proposed Fix - FontView Cleanup (5.57 KB, patch)
2010-05-05 00:25 PDT, Joseph Pecoraro
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Joseph Pecoraro 2010-05-05 00:17:44 PDT
When refactoring SourceView / ImageView it looks like FontView was missed. Also, make calculation based on a slightly narrower area to prevent lines from widowing.
Comment 1 Joseph Pecoraro 2010-05-05 00:19:30 PDT
Created attachment 55091 [details]
[IMAGE] FontView Before
Comment 2 Joseph Pecoraro 2010-05-05 00:19:53 PDT
Created attachment 55092 [details]
[IMAGE] FontView After
Comment 3 Joseph Pecoraro 2010-05-05 00:25:29 PDT
Created attachment 55093 [details]
[PATCH] Proposed Fix - FontView Cleanup

The patch looks a lot scarier then it actually is.

- moved some code down from the constructor to contentTabSelected
- changed some variables to const for clarity
- cached the number of lines in this._lineCount (we may need to remove this if we allow the users to edit the text on the fly! see bug 16232!)
Comment 4 WebKit Commit Bot 2010-05-05 00:57:17 PDT
Comment on attachment 55093 [details]
[PATCH] Proposed Fix - FontView Cleanup

Clearing flags on attachment: 55093

Committed r58805: <http://trac.webkit.org/changeset/58805>
Comment 5 WebKit Commit Bot 2010-05-05 00:57:23 PDT
All reviewed patches have been landed.  Closing bug.