Bug 38549 - [WebKit2] The web process doesn't need to paint when the web view is hidden.
Summary: [WebKit2] The web process doesn't need to paint when the web view is hidden.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Other OS X 10.5
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-05-04 14:19 PDT by Anders Carlsson
Modified: 2010-05-04 15:24 PDT (History)
0 users

See Also:


Attachments
Patch (6.40 KB, patch)
2010-05-04 14:26 PDT, Anders Carlsson
mitz: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Anders Carlsson 2010-05-04 14:19:53 PDT
[WebKit2] The web process doesn't need to paint when the web view is hidden.
Comment 1 Anders Carlsson 2010-05-04 14:26:47 PDT
Created attachment 55050 [details]
Patch
Comment 2 mitz 2010-05-04 14:46:23 PDT
Comment on attachment 55050 [details]
Patch

> +void DrawingAreaUpdateChunk::suspendPainting()
> +{
> +    ASSERT(m_shouldPaint);

Do you really want to assert this?

> +void DrawingAreaUpdateChunk::resumePainting()
> +{
> +    ASSERT(!m_shouldPaint);

Do you really want to assert this?

r=me if you change “paint” to “update” and “painting” to “updating”.
Comment 3 Anders Carlsson 2010-05-04 14:56:57 PDT
(In reply to comment #2)
> (From update of attachment 55050 [details])
> > +void DrawingAreaUpdateChunk::suspendPainting()
> > +{
> > +    ASSERT(m_shouldPaint);
> 
> Do you really want to assert this?
> 

I figured it wouldn't hurt! If it's a problem we can always remove it later.

> > +void DrawingAreaUpdateChunk::resumePainting()
> > +{
> > +    ASSERT(!m_shouldPaint);
> 
> Do you really want to assert this?
> 

I figured it wouldn't hurt! If it's a problem we can always remove it later.

> r=me if you change “paint” to “update” and “painting” to “updating”.

Will do, thanks!
Comment 4 Anders Carlsson 2010-05-04 15:24:25 PDT
Committed r58781: <http://trac.webkit.org/changeset/58781>