Bug 38545 - extract-localizable-strings script miss files when skip directories are specified
Summary: extract-localizable-strings script miss files when skip directories are speci...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC OS X 10.5
: P2 Normal
Assignee: Timothy Hatcher
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-05-04 14:05 PDT by Timothy Hatcher
Modified: 2010-05-04 21:27 PDT (History)
1 user (show)

See Also:


Attachments
Proposed patch (3.60 KB, patch)
2010-05-04 14:17 PDT, Timothy Hatcher
darin: review+
timothy: commit-queue-
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Timothy Hatcher 2010-05-04 14:05:10 PDT
The extract-localizable-strings script's use of -prune gets lumped into the first match causing it to skip "*.h" files. This caused <rdar://problem/7940701>.

We need to fix the arguments we pass to find in this script.
Comment 1 Darin Adler 2010-05-04 14:12:32 PDT
I think we want to have this say "-prune -false -o" instead of just "-prune".
Comment 2 Timothy Hatcher 2010-05-04 14:17:41 PDT
Created attachment 55048 [details]
Proposed patch
Comment 3 Timothy Hatcher 2010-05-04 14:23:21 PDT
It seems to work this way, since -prune is an action it does not cause the results to print (no implict -print action for those.)

That is my understanding how it works.
Comment 4 Timothy Hatcher 2010-05-04 14:25:03 PDT
But that dosen't match what the man page says:

If none of -exec, -ls, -print, -print0, or -ok is specified, the given expression shall be effectively replaced by ( given expression ) -print.
Comment 5 Timothy Hatcher 2010-05-04 14:26:44 PDT
Doing "-prune -false" has the same effect as "-prune".
Comment 6 Timothy Hatcher 2010-05-04 21:27:19 PDT
Landed in r58777.