Bug 38544 - MAC_JAVA_BRIDGE should be renamed JAVA_BRIDGE
Summary: MAC_JAVA_BRIDGE should be renamed JAVA_BRIDGE
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore Misc. (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-05-04 13:48 PDT by Steve Block
Modified: 2010-05-06 07:10 PDT (History)
3 users (show)

See Also:


Attachments
Patch (17.27 KB, patch)
2010-05-04 15:36 PDT, Steve Block
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Steve Block 2010-05-04 13:48:15 PDT
MAC_JAVA_BRIDGE is used on both Mac and ANDROID. It should be renamed JAVA_BRIDGE.
Comment 1 Steve Block 2010-05-04 15:36:20 PDT
Created attachment 55061 [details]
Patch
Comment 2 Eric Seidel (no email) 2010-05-05 21:54:26 PDT
Comment on attachment 55061 [details]
Patch

OK.  But why not JNI_BRIDGE to match the class names?
Comment 3 Steve Block 2010-05-06 05:56:36 PDT
> But why not JNI_BRIDGE to match the class names?
The classes are prefixed with 'Java', though it's true that some of the files are prefixed with 'JNI'. I think that 'Java' makes more sense, as it's the language to which we're bridging.
Comment 4 WebKit Commit Bot 2010-05-06 07:10:03 PDT
Comment on attachment 55061 [details]
Patch

Clearing flags on attachment: 55061

Committed r58878: <http://trac.webkit.org/changeset/58878>
Comment 5 WebKit Commit Bot 2010-05-06 07:10:08 PDT
All reviewed patches have been landed.  Closing bug.