Bug 38542 - Web Inspector: Clickable links to resources should be used as 'details' part for the all suitable kinds of records.
Summary: Web Inspector: Clickable links to resources should be used as 'details' part ...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (Deprecated) (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-05-04 13:40 PDT by Ilya Tikhonovsky
Modified: 2010-05-05 04:36 PDT (History)
3 users (show)

See Also:

Attachments
screenshot. (45.35 KB, image/png)
2010-05-04 13:40 PDT, Ilya Tikhonovsky 		no flags Details
[patch] Initial version. (19.53 KB, patch)
2010-05-04 13:48 PDT, Ilya Tikhonovsky 		pfeldman: review+
Details | Formatted Diff | Diff
[patch] landed version. (19.80 KB, patch)
2010-05-05 04:36 PDT, Ilya Tikhonovsky 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Ilya Tikhonovsky 2010-05-04 13:40:59 PDT 
Created attachment 55041 [details]
screenshot.

Direct link to resources should be used as 'details' part of record for all suitable record types.
As far as we definitely have a single child FunctionCall event for each TimerFire event we should propagate FunctionCall record's data to its parent TimerFire record.
Comment 1 Ilya Tikhonovsky 2010-05-04 13:48:45 PDT 
Created attachment 55042 [details]
[patch] Initial version.
Comment 2 Pavel Feldman 2010-05-04 23:44:37 PDT 
Comment on attachment 55042 [details]
[patch] Initial version.

WebCore/inspector/front-end/TimelinePanel.js:1002
 +  WebInspector.TimelinePanel.FormattedRecord.PopupContentHelper = function(title)
This could be WebInspector.TimelinePanel.PopupContentHelper or WebInspector.TimelinePopupContentHelper. No need to create nesting that deep. Same for FromattedRecord itself.

Please fix before landing!
Comment 3 Ilya Tikhonovsky 2010-05-05 04:31:02 PDT 
Committing to http://svn.webkit.org/repository/webkit/trunk ...
	M	WebCore/ChangeLog
	M	WebCore/inspector/front-end/TimelinePanel.js
Committed r58809
Comment 4 Ilya Tikhonovsky 2010-05-05 04:36:37 PDT 
Created attachment 55106 [details]
[patch] landed version.

PopupContentHelper was renamed.
'details' part of Timer related records was adjusted for WebKit case where we have no information about caller and callback function.