Bug 38521 - New FileSystemPOSIX functions cause linker errors on Android
Summary: New FileSystemPOSIX functions cause linker errors on Android
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore Misc. (show other bugs)
Version: 528+ (Nightly build)
Hardware: Android Android
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-05-04 08:20 PDT by Steve Block
Modified: 2010-05-04 14:02 PDT (History)
3 users (show)

See Also:


Attachments
Patch (1.96 KB, patch)
2010-05-04 08:45 PDT, Steve Block
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Steve Block 2010-05-04 08:20:48 PDT
Android uses FileSystemPOSIX.cpp but also uses additional functions in FileSystemAndroid.cpp. http://trac.webkit.org/changeset/57182 added a number of new functions to FileSystemPOSIX.cpp, of which two (closeFile and writeToFile) are already present in FileSystemAndroid.cpp. This causes link errors on Android due to multiply defined symbols.
Comment 1 Steve Block 2010-05-04 08:45:47 PDT
Created attachment 55022 [details]
Patch
Comment 2 WebKit Commit Bot 2010-05-04 14:02:53 PDT
Comment on attachment 55022 [details]
Patch

Clearing flags on attachment: 55022

Committed r58774: <http://trac.webkit.org/changeset/58774>
Comment 3 WebKit Commit Bot 2010-05-04 14:02:58 PDT
All reviewed patches have been landed.  Closing bug.