Bug 38517 - Commit and Review policy should encourage unofficial reviews
Summary: Commit and Review policy should encourage unofficial reviews
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit Website (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-05-04 07:09 PDT by Shinichiro Hamaji
Modified: 2010-05-05 10:53 PDT (History)
0 users

See Also:


Attachments
Patch v1 (1.35 KB, patch)
2010-05-04 07:10 PDT, Shinichiro Hamaji
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Shinichiro Hamaji 2010-05-04 07:09:31 PDT
It would be better to encourage unofficial reviews in

http://webkit.org/coding/commit-review-policy.html
Comment 1 Shinichiro Hamaji 2010-05-04 07:10:39 PDT
Created attachment 55017 [details]
Patch v1
Comment 2 Adam Barth 2010-05-05 10:12:06 PDT
Comment on attachment 55017 [details]
Patch v1

LGTM.
Comment 3 Shinichiro Hamaji 2010-05-05 10:53:51 PDT
Comment on attachment 55017 [details]
Patch v1

Clearing flags on attachment: 55017

Committed r58827: <http://trac.webkit.org/changeset/58827>
Comment 4 Shinichiro Hamaji 2010-05-05 10:53:58 PDT
All reviewed patches have been landed.  Closing bug.