Bug 38513 - Split SVGCharacterLayoutInfo in smaller pieces
Summary: Split SVGCharacterLayoutInfo in smaller pieces
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: SVG (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Nikolas Zimmermann
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-05-04 03:32 PDT by Nikolas Zimmermann
Modified: 2010-05-04 05:08 PDT (History)
2 users (show)

See Also:

Attachments
Patch (88.53 KB, patch)
2010-05-04 03:54 PDT, Nikolas Zimmermann 		krit: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Nikolas Zimmermann 2010-05-04 03:32:01 PDT 
SVGCharacterLayoutInfo is convoluted, it should be split up.
Comment 1 Nikolas Zimmermann 2010-05-04 03:50:09 PDT 
Two style errors in the upcoming patch, on purpose.
Need to check whether floats are equal to 0.0f, can't use ! operator.
Comment 2 Nikolas Zimmermann 2010-05-04 03:54:58 PDT 
Created attachment 55007 [details]
Patch
Comment 3 WebKit Review Bot 2010-05-04 03:57:29 PDT 
Attachment 55007 [details] did not pass style-queue:

Failed to run "['WebKitTools/Scripts/check-webkit-style', '--no-squash']" exit_code: 1
WebCore/rendering/SVGCharacterLayoutInfo.cpp:171:  Tests for true/false, null/non-null, and zero/non-zero should all be done without equality comparisons.  [readability/comparison_to_zero] [5]
WebCore/rendering/SVGCharacterLayoutInfo.cpp:172:  Tests for true/false, null/non-null, and zero/non-zero should all be done without equality comparisons.  [readability/comparison_to_zero] [5]
Total errors found: 2 in 14 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 4 Dirk Schulze 2010-05-04 04:17:34 PDT 
Comment on attachment 55007 [details]
Patch

LGTM r=me
Comment 5 Nikolas Zimmermann 2010-05-04 05:08:29 PDT 
Committed r58751: <http://trac.webkit.org/changeset/58751>