RESOLVED FIXED 38513
Split SVGCharacterLayoutInfo in smaller pieces 
https://bugs.webkit.org/show_bug.cgi?id=38513
Summary Split SVGCharacterLayoutInfo in smaller pieces
Nikolas Zimmermann
Reported 2010-05-04 03:32:01 PDT
SVGCharacterLayoutInfo is convoluted, it should be split up.
Attachments
Patch (88.53 KB, patch)
2010-05-04 03:54 PDT, Nikolas Zimmermann 		krit: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Nikolas Zimmermann
Comment 1 2010-05-04 03:50:09 PDT
Two style errors in the upcoming patch, on purpose. Need to check whether floats are equal to 0.0f, can't use ! operator.
Nikolas Zimmermann
Comment 2 2010-05-04 03:54:58 PDT
Created attachment 55007 [details] Patch
WebKit Review Bot
Comment 3 2010-05-04 03:57:29 PDT
Attachment 55007 [details] did not pass style-queue: Failed to run "['WebKitTools/Scripts/check-webkit-style', '--no-squash']" exit_code: 1 WebCore/rendering/SVGCharacterLayoutInfo.cpp:171: Tests for true/false, null/non-null, and zero/non-zero should all be done without equality comparisons. [readability/comparison_to_zero] [5] WebCore/rendering/SVGCharacterLayoutInfo.cpp:172: Tests for true/false, null/non-null, and zero/non-zero should all be done without equality comparisons. [readability/comparison_to_zero] [5] Total errors found: 2 in 14 files If any of these errors are false positives, please file a bug against check-webkit-style.
Dirk Schulze
Comment 4 2010-05-04 04:17:34 PDT
Comment on attachment 55007 [details] Patch LGTM r=me
Nikolas Zimmermann
Comment 5 2010-05-04 05:08:29 PDT
Committed r58751: <http://trac.webkit.org/changeset/58751>
Note You need to log in before you can comment on or make changes to this bug.