Bug 38511 - [Qt] Remove WinCE endian dedection.
Summary: [Qt] Remove WinCE endian dedection.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Template Framework (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Patrick R. Gansterer
URL:
Keywords: Qt, QtTriaged
Depends on: 37434
Blocks:
  Show dependency treegraph
 
Reported: 2010-05-04 02:01 PDT by Patrick R. Gansterer
Modified: 2010-05-17 01:43 PDT (History)
7 users (show)

See Also:


Attachments
The patch (1.43 KB, patch)
2010-05-04 02:03 PDT, Patrick R. Gansterer
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Patrick R. Gansterer 2010-05-04 02:01:59 PDT
See patch.
Comment 1 Patrick R. Gansterer 2010-05-04 02:03:20 PDT
Created attachment 55003 [details]
The patch
Comment 2 Laszlo Gombos 2010-05-04 10:43:01 PDT
Patrick, the change looks good to me. Have you had a chance to test it on WinCE?
Comment 3 Patrick R. Gansterer 2010-05-04 10:48:38 PDT
(In reply to comment #2)
> Patrick, the change looks good to me. Have you had a chance to test it on
> WinCE?
No, I didn't. (It takes sooo much time)
I can compile it with this patch if it's necessary, but I don't think so. ;-)
Comment 4 Laszlo Gombos 2010-05-04 10:59:09 PDT
As we do not have a buildbot for WinCE I would feel better if we could actually test this build change. Only the QtWebKit port on WinCE is impacted.  

Should we find someone else to test this with QtWebKit ?
Comment 5 Patrick R. Gansterer 2010-05-04 11:03:20 PDT
(In reply to comment #4)
> As we do not have a buildbot for WinCE I would feel better if we could actually
> test this build change. Only the QtWebKit port on WinCE is impacted.  
> 
> Should we find someone else to test this with QtWebKit ?
I'll try to get it running, but I had many troubles compiling QtWebKit for WinCE directly from svn trunk the last time. It doesn't work as nice as from a Qt release. ;-)
Comment 6 Laszlo Gombos 2010-05-05 13:09:22 PDT
Comment on attachment 55003 [details]
The patch

r+ for the patch, but cq- until it is confirmed that this does not breaks the build.

Thanks for the clean-up, this moves the code to the right direction.
Comment 7 Jesus Sanchez-Palencia 2010-05-12 06:49:24 PDT
Triaged but I'm not adding it as QtWebKit 2.0 blocker as I don't know if you want this.
Comment 8 Patrick R. Gansterer 2010-05-14 02:21:01 PDT
Comment on attachment 55003 [details]
The patch

It took a lot of time to compile it out of trunk for WinCE, but it works with this patch.
Comment 9 WebKit Commit Bot 2010-05-17 01:11:21 PDT
Comment on attachment 55003 [details]
The patch

Clearing flags on attachment: 55003

Committed r59600: <http://trac.webkit.org/changeset/59600>
Comment 10 WebKit Commit Bot 2010-05-17 01:11:26 PDT
All reviewed patches have been landed.  Closing bug.
Comment 11 WebKit Review Bot 2010-05-17 01:40:54 PDT
http://trac.webkit.org/changeset/59600 might have broken Qt Linux ARMv7 Release
The following changes are on the blame list:
http://trac.webkit.org/changeset/59600
http://trac.webkit.org/changeset/59599
Comment 12 Eric Seidel (no email) 2010-05-17 01:43:33 PDT
Sorry.  The qt builders just got disconnected.  I think we may need to remove them from the sheriff-bot watch until they can get a better internet connection.