Bug 38508 – [chromium] WebViewClient should have a notification when a new node gets the focus

• Status: RESOLVED
• Resolution: FIXED
• Component: WebKit Misc.

[Jay Civelli]

Right now the ChromeClient focus method is called every time a new node gets the focus, without specifying which node got focused.
We should have a notification on the WebViewClient when a node gets focus, which specify that node.

[Jay Civelli]

Created attachment 54998 [details]
Adding a notification on WebViewClient for focus change events.

[Darin Fisher (:fishd, Google)]

Comment on attachment 54998 [details]
Adding a notification on WebViewClient for focus change events.

WebKit/chromium/public/WebViewClient.h:106
 +      virtual void focusNodeChanged(const WebNode&) { }
How about moving this down near the other focus related methods?
(In the UI section.)

WebKit/chromium/src/ChromeClientImpl.cpp:218
 +      m_webView->client()->focusNodeChanged(WebNode(node));
focusedNodeChanged seems like a better name for this method.

[Jay Civelli]

Created attachment 55322 [details]
Applying fishd's comments

[WebKit Commit Bot]

Comment on attachment 55322 [details]
Applying fishd's comments

Rejecting patch 55322 from commit-queue.

Unexpected failure when landing patch!  Please file a bug against webkit-patch.
Failed to run "['./WebKitTools/Scripts/webkit-patch', '--status-host=webkit-commit-queue.appspot.com', 'land-attachment', '--force-clean', '--build', '--test', '--non-interactive', '--ignore-builders', '--build-style=both', '--quiet', 55322, '--parent-command=commit-queue', '--no-update']" exit_code: 1
Logging in as [e-mail]...
Fetching: https://bugs.webkit.org/attachment.cgi?id=55322&action=edit
Fetching: https://bugs.webkit.org/show_bug.cgi?id=38508&ctype=xml
Processing 1 patch from 1 bug.
Cleaning working directory
Processing patch 55322 from bug 38508.
ERROR: /Users/eseidel/Projects/CommitQueue/WebKit/chromium/ChangeLog neither lists a valid reviewer nor contains the string "Unreviewed" or "Rubber stamp" (case insensitive).

[Adam Barth]

Created attachment 56143 [details]
Patch for landing

[Adam Barth]

In the future, please do not remove the Reviewed by NOBODY line from the ChangeLog.  It is used by the automated tools to fill in the reviewer properly.

[WebKit Commit Bot]

Comment on attachment 56143 [details]
Patch for landing

Clearing flags on attachment: 56143

Committed r59543: <http://trac.webkit.org/changeset/59543>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.