Bug 38504 – new-run-webkit-tests: --verbose is not printing everything

• Status: RESOLVED
• Resolution: FIXED
• Component: New Bugs

[Dirk Pranke]

new-run-webkit-tests: --verbose is not printing everything

[Dirk Pranke]

Created attachment 54985 [details]
Patch

[Dirk Pranke]

Committed r58731: <http://trac.webkit.org/changeset/58731>

[Eric Seidel (no email)]

Comment on attachment 54985 [details]
Patch

I see you've already landed... but this really should have a unit test to confirm that self.switches is set to the same thing as --print everything would.

[Dirk Pranke]

Yeah, I sort of wanted to get feedback on this bug on what the right fix should be before I wrote unit tests for it. Should --print override --verbose (which is what this patch does), or vice versa?

Admittedly, landing before figuring this out is a bad thing, but the bots were already borked, so I figured it was a lesser of two evils thing (and I didn't want to back out the offending change).

[Eric Seidel (no email)]

I think --print should probably override --verbose.  Otherwise you can't add verbosity.  Then again, --verbose could just imply --print=verbose which was the set of settings enabled by default for verbose. :)

[Ojan Vafai]

I don't see why we should worry about overriding. Lets just throw an error if you try to specify both.

[Dirk Pranke]

(In reply to comment #6)
> I don't see why we should worry about overriding. Lets just throw an error if
> you try to specify both.

The only real advantage I could see to allowing both would be if you wanted the equivalent of --print everything,trace-everything (i.e., verbose + tracing)