RESOLVED FIXED38500
[chromium] use glyphDataForCharacter so we hit the glyphdata cache 
https://bugs.webkit.org/show_bug.cgi?id=38500
Summary [chromium] use glyphDataForCharacter so we hit the glyphdata cache
Evan Martin
Reported 2010-05-03 17:45:58 PDT
[chromium] use glyphDataForCharacter so we hit the glyphdata cache
Attachments
Patch (3.85 KB, patch)
2010-05-03 17:58 PDT, Evan Martin 		eric: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Evan Martin
Comment 1 2010-05-03 17:58:44 PDT
Created attachment 54980 [details] Patch
Evan Martin
Comment 2 2010-05-03 18:16:05 PDT
Before/after numbers: [ OK ] PageCyclerReferenceTest.Intl2File (86605 ms) [ OK ] PageCyclerTest.Intl2File (51034 ms) 41% performance improvement.
Adam Langley
Comment 3 2010-05-04 08:01:58 PDT
What about the m_iterateBackwards case? Isn't the same thing needed there?
Evan Martin
Comment 4 2010-05-04 08:42:18 PDT
Yes, and this is also incorrect for surrogate pairs. I intend (after getting the bold Bengali patch through, sigh) to revisit this. Either I'll make it solely in terms of iterating through characters (what my new for loop adds) or we'll have Harfbuzz-ng in a state where the iteration will likely be different in some other way.
Adam Langley
Comment 5 2010-05-04 08:49:02 PDT
ok, LGTM then.
Darin Fisher (:fishd, Google)
Comment 6 2010-05-04 22:02:12 PDT
Comment on attachment 54980 [details] Patch WebCore/ChangeLog:18 + Tests: fast/text/international/danda-space.html spacing changes slightly did you intend to include new baselines?
Evan Martin
Comment 7 2010-05-04 23:25:30 PDT
There were minor antialiasing differences that I was hoping were due to 64-bit/32-bit issues, so my plan was to pull them off the buildbot.
Eric Seidel (no email)
Comment 8 2010-05-05 22:04:51 PDT
Comment on attachment 54980 [details] Patch OK.
Eric Seidel (no email)
Comment 9 2010-05-05 22:05:25 PDT
CCing international text gurus mitz and ap just in case they're care to see this pass by.
Eric Seidel (no email)
Comment 10 2010-05-08 23:15:39 PDT
Attachment 54980 [details] was posted by a committer and has review+, assigning to Evan Martin for commit.
Evan Martin
Comment 11 2010-05-08 23:18:59 PDT
Committed this before, but webkit-patch glitched.
Note You need to log in before you can comment on or make changes to this bug.