RESOLVED FIXED38486
Maui MiniBrowser: Add an option to show/hide the web view 
https://bugs.webkit.org/show_bug.cgi?id=38486
Summary Maui MiniBrowser: Add an option to show/hide the web view
Anders Carlsson
Reported 2010-05-03 14:13:01 PDT
Maui MiniBrowser: Add an option to show/hide the web view
Attachments
Patch (4.80 KB, patch)
2010-05-03 14:17 PDT, Anders Carlsson 		aroben: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Anders Carlsson
Comment 1 2010-05-03 14:17:58 PDT
Created attachment 54960 [details] Patch
Adam Roben (:aroben)
Comment 2 2010-05-03 14:22:32 PDT
Comment on attachment 54960 [details] Patch > + * MiniBrowser/win/BrowserWindow.cpp: > + (BrowserWindow::createWindow): > + (BrowserWindow::onCommand): > + * MiniBrowser/win/MiniBrowser.rc: > + * MiniBrowser/win/resource.h: More details, please! > + case ID_DEBUG_SHOW_WEB_VIEW: { > + HMENU menu = ::GetMenu(m_window); > + bool isChecked = ::GetMenuState(menu, ID_DEBUG_SHOW_WEB_VIEW, MF_BYCOMMAND) & MF_CHECKED; I would call this variable shouldHide. Or reverse it and call it shouldShow. r=me
Anders Carlsson
Comment 3 2010-05-03 14:35:29 PDT
Committed r58701: <http://trac.webkit.org/changeset/58701>
Note You need to log in before you can comment on or make changes to this bug.