Bug 38483 - Implement PageClient::isPageVisible on Windows.
Summary: Implement PageClient::isPageVisible on Windows.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Other OS X 10.5
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-05-03 13:00 PDT by Anders Carlsson
Modified: 2010-05-03 13:19 PDT (History)
0 users

See Also:

Attachments
Patch (2.27 KB, patch)
2010-05-03 13:06 PDT, Anders Carlsson 		aroben: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Anders Carlsson 2010-05-03 13:00:03 PDT 
Implement PageClient::isPageVisible on Windows.
Comment 1 Anders Carlsson 2010-05-03 13:06:00 PDT 
Created attachment 54956 [details]
Patch
Comment 2 Adam Roben (:aroben) 2010-05-03 13:10:16 PDT 
Comment on attachment 54956 [details]
Patch

Is it possible for m_window to be null?

The FIXME seems incorrect if it's possible for m_window to be a top-level window.

You could add a FIXME about checking if the window is clipped out of view.

r=me
Comment 3 Anders Carlsson 2010-05-03 13:11:59 PDT 
(In reply to comment #2)
> (From update of attachment 54956 [details])
> Is it possible for m_window to be null?
> 

Nope.

> The FIXME seems incorrect if it's possible for m_window to be a top-level
> window.

It will never be a top-level window.

> 
> You could add a FIXME about checking if the window is clipped out of view.

In that case I think we might still want to update the backing store; this is more to stop updates from web views in hidden tabs from happening.

> 
> r=me

Thanks!
Comment 4 Anders Carlsson 2010-05-03 13:19:58 PDT 
Committed r58697: <http://trac.webkit.org/changeset/58697>