Bug 38482 - wx port: mac lacks complex text support
: wx port: mac lacks complex text support
Status: RESOLVED FIXED
: WebKit
WebKit wx
: 528+ (Nightly build)
: Macintosh Mac OS X 10.5
: P2 Normal
Assigned To:
:
:
:
:
  Show dependency treegraph
 
Reported: 2010-05-03 12:39 PST by
Modified: 2010-05-03 16:51 PST (History)


Attachments
Build and use Mac's ComplexTextController to support complex text in wx (34.17 KB, patch)
2010-05-03 12:39 PST, Kevin Watters
kevino: review+
kevino: commit‑queue-
Review Patch | Details | Formatted Diff | Diff


Note

You need to log in before you can comment on or make changes to this bug.


Description From 2010-05-03 12:39:28 PST
Created an attachment (id=54955) [details]
Build and use Mac's ComplexTextController to support complex text in wx

We could use the Mac implementation of ComplexTextController to support complex scripts on wxMac.
------- Comment #1 From 2010-05-03 12:48:25 PST -------
Attachment 54955 [details] did not pass style-queue:

Failed to run "['WebKitTools/Scripts/check-webkit-style', '--no-squash']" exit_code: 1
WebCore/platform/graphics/SimpleFontData.h:128:  Extra space before ( in function call  [whitespace/parens] [4]
Total errors found: 1 in 24 files


If any of these errors are false positives, please file a bug against check-webkit-style.
------- Comment #2 From 2010-05-03 15:32:20 PST -------
Landed in r58707, thanks!
------- Comment #3 From 2010-05-03 16:51:47 PST -------
http://trac.webkit.org/changeset/58707 might have broken Qt Linux Release minimal