Bug 38480 - wx port: scheduleDispatchFunctionsOnMainThread is unimplemented
Summary: wx port: scheduleDispatchFunctionsOnMainThread is unimplemented
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit wx (show other bugs)
Version: 528+ (Nightly build)
Hardware: All OS X 10.5
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-05-03 12:29 PDT by Kevin Watters
Modified: 2010-05-03 15:37 PDT (History)
2 users (show)

See Also:


Attachments
implements scheduleDispatchFunctionsOnMainThread (1.65 KB, patch)
2010-05-03 12:29 PDT, Kevin Watters
kevino: review+
kevino: commit-queue-
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Kevin Watters 2010-05-03 12:29:09 PDT
Created attachment 54953 [details]
implements scheduleDispatchFunctionsOnMainThread

The wx port needs an implementation for scheduleDispatchFunctionsOnMainThread in MainThreadWx.cpp.
Comment 1 WebKit Review Bot 2010-05-03 12:34:01 PDT
Attachment 54953 [details] did not pass style-queue:

Failed to run "['WebKitTools/Scripts/check-webkit-style', '--no-squash']" exit_code: 1
JavaScriptCore/wtf/wx/MainThreadWx.cpp:33:  Alphabetical sorting problem.  [build/include_order] [4]
JavaScriptCore/wtf/wx/MainThreadWx.cpp:36:  wxEVT_CALL_AFTER is incorrectly named. Don't use underscores in your identifier names.  [readability/naming] [4]
JavaScriptCore/wtf/wx/MainThreadWx.cpp:39:  This { should be at the end of the previous line  [whitespace/braces] [4]
Total errors found: 3 in 2 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 2 Kevin Ollivier 2010-05-03 12:39:46 PDT
These style issues are due to conflict with wx header and naming conventions, so I'm approving this patch.
Comment 3 Kevin Ollivier 2010-05-03 15:37:56 PDT
Landed in r58709, thanks!