Bug 3847 - GW: add Cap support to QRegExp
Summary: GW: add Cap support to QRegExp
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 420+
Hardware: Mac OS X 10.4
: P4 Enhancement
Assignee: Eric Seidel (no email)
URL:
Keywords:
Depends on:
Blocks: 3250
  Show dependency tree / graph
 
Reported: 2005-07-04 01:37 PDT by Eric Seidel (no email)
Modified: 2005-07-08 18:15 PDT (History)
0 users

See Also:

Attachments
a little more tricky than some, but should still be easily understandable (3.33 KB, patch)
2005-07-04 01:38 PDT, Eric Seidel (no email) 		mjs: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Eric Seidel (no email) 2005-07-04 01:37:31 PDT 
The attached patch adds QRegExp::cap(int) support to KWQ.
Comment 1 Eric Seidel (no email) 2005-07-04 01:38:40 PDT 
Created attachment 2785 [details]
a little more tricky than some, but should still be easily understandable
Comment 2 Maciej Stachowiak 2005-07-07 21:30:29 PDT 
Comment on attachment 2785 [details]
a little more tricky than some, but should still be easily understandable

r=me

Make sure to test performance before landing.

minor style nitpick: we prefer no braces around single-line if bodies. Please
fix that before landing.
Comment 3 Maciej Stachowiak 2005-07-07 21:34:05 PDT 
Comment on attachment 2785 [details]
a little more tricky than some, but should still be easily understandable

r=me

Make sure to test performance before landing.

minor style nitpick: we prefer no braces around single-line if bodies. Please
fix that before landing.
Comment 4 Eric Seidel (no email) 2005-07-08 18:07:23 PDT 
I ran autovicki.  No performance regressions:

Before: cvs-base AvgCached:     0.144
After: cvs-base AvgCached:     0.144