RESOLVED FIXED 3847
GW: add Cap support to QRegExp 
https://bugs.webkit.org/show_bug.cgi?id=3847
Summary GW: add Cap support to QRegExp
Eric Seidel (no email)
Reported 2005-07-04 01:37:31 PDT
The attached patch adds QRegExp::cap(int) support to KWQ.
Attachments
a little more tricky than some, but should still be easily understandable (3.33 KB, patch)
2005-07-04 01:38 PDT, Eric Seidel (no email) 		mjs: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Eric Seidel (no email)
Comment 1 2005-07-04 01:38:40 PDT
Created attachment 2785 [details] a little more tricky than some, but should still be easily understandable
Maciej Stachowiak
Comment 2 2005-07-07 21:30:29 PDT
Comment on attachment 2785 [details] a little more tricky than some, but should still be easily understandable r=me Make sure to test performance before landing. minor style nitpick: we prefer no braces around single-line if bodies. Please fix that before landing.
Maciej Stachowiak
Comment 3 2005-07-07 21:34:05 PDT
Comment on attachment 2785 [details] a little more tricky than some, but should still be easily understandable r=me Make sure to test performance before landing. minor style nitpick: we prefer no braces around single-line if bodies. Please fix that before landing.
Eric Seidel (no email)
Comment 4 2005-07-08 18:07:23 PDT
I ran autovicki. No performance regressions: Before: cvs-base AvgCached: 0.144 After: cvs-base AvgCached: 0.144
Note You need to log in before you can comment on or make changes to this bug.