Bug 38435 – [Qt] Unskip editing/pasteboard tests that fail due to 'x,y' differences

• Status: CLOSED
• Resolution: FIXED
• Component: Tools / Tests

[Robert Hogan]

Unskip a large number of editing/pasteboard tests that fail only due
    to rendertree differences in the height/width of rendered text.

    Reduce the skipped editing/pasteboard tests to those that fail for
    a good reason and add some initial commentary on each.

    Since the size of the text rendered by the Qt buildbot is unpredictable
    ( :-/ ) I will land platform-specific expected results for each test
    that fails after commit as unreviewed.

Tests to unskip are:


editing/pasteboard/3976872.html
editing/pasteboard/4076267-3.html
editing/pasteboard/4242293.html
editing/pasteboard/4631972.html
editing/pasteboard/4641033.html
editing/pasteboard/4700297.html
editing/pasteboard/4806874.html
editing/pasteboard/4840662.html
editing/pasteboard/4944770-1.html
editing/pasteboard/4944770-2.html
editing/pasteboard/4989774.html
editing/pasteboard/5006779.html
editing/pasteboard/5027857.html
editing/pasteboard/5028447.html
editing/pasteboard/5032095.html
editing/pasteboard/5065605.html
editing/pasteboard/5071074-2.html
editing/pasteboard/5071074.html
editing/pasteboard/5075944-2.html
editing/pasteboard/5075944-3.html
editing/pasteboard/5075944.html
editing/pasteboard/5089327.html
editing/pasteboard/5134759.html
editing/pasteboard/5156401-1.html
editing/pasteboard/5245519.html
editing/pasteboard/5247341.html
editing/pasteboard/5368833.html
editing/pasteboard/5478250.html
editing/pasteboard/5483567.html
editing/pasteboard/5601583-1.html
editing/pasteboard/5780697-2.html
editing/pasteboard/7955.html
editing/pasteboard/8145-1.html
editing/pasteboard/8145-2.html
editing/pasteboard/8145-3.html
editing/pasteboard/copy-paste-bidi.html
editing/pasteboard/cut-text-001.html
editing/pasteboard/displaced-generic-placeholder.html
editing/pasteboard/displaced-placeholder.html
editing/pasteboard/display-block-on-spans.html
editing/pasteboard/emacs-cntl-y-001.html
editing/pasteboard/innerText-inline-table.html
editing/pasteboard/interchange-newline-1.html
editing/pasteboard/interchange-newline-3.html
editing/pasteboard/interchange-newline-4.html
editing/pasteboard/merge-after-delete-1.html
editing/pasteboard/merge-after-delete-2.html
editing/pasteboard/merge-after-delete.html
editing/pasteboard/merge-end-1.html
editing/pasteboard/merge-end-2.html
editing/pasteboard/merge-end-3.html
editing/pasteboard/merge-end-4.html
editing/pasteboard/merge-end-5.html
editing/pasteboard/merge-end-blockquote.html
editing/pasteboard/merge-end-borders.html
editing/pasteboard/merge-end-list.html
editing/pasteboard/merge-end-table.html
editing/pasteboard/merge-start-blockquote.html
editing/pasteboard/merge-start-list.html
editing/pasteboard/nested-blocks-with-text-area.html
editing/pasteboard/nested-blocks-with-text-area.html
editing/pasteboard/nested-blocks-with-text-field.html
editing/pasteboard/nested-blocks-with-text-field.html
editing/pasteboard/paste-4035648-fix.html
editing/pasteboard/paste-4038267-fix.html
editing/pasteboard/paste-4039777-fix.html
editing/pasteboard/paste-blockquote-1.html
editing/pasteboard/paste-blockquote-2.html
editing/pasteboard/paste-blockquote-3.html
editing/pasteboard/paste-blockquote-after-blockquote.html
editing/pasteboard/paste-blockquote-into-blockquote-2.html
editing/pasteboard/paste-blockquote-into-blockquote-3.html
editing/pasteboard/paste-blockquote-into-blockquote-4.html
editing/pasteboard/paste-blockquote-into-blockquote.html
editing/pasteboard/paste-line-endings-001.html
editing/pasteboard/paste-line-endings-002.html
editing/pasteboard/paste-line-endings-003.html
editing/pasteboard/paste-line-endings-004.html
editing/pasteboard/paste-line-endings-005.html
editing/pasteboard/paste-line-endings-006.html
editing/pasteboard/paste-line-endings-007.html
editing/pasteboard/paste-line-endings-008.html
editing/pasteboard/paste-line-endings-009.html
editing/pasteboard/paste-line-endings-010.html
editing/pasteboard/paste-list-001.html
editing/pasteboard/paste-match-style-001.html
editing/pasteboard/paste-match-style-002.html
editing/pasteboard/paste-pre-001.html
editing/pasteboard/paste-pre-002.html
editing/pasteboard/paste-table-001.html
editing/pasteboard/paste-table-003.html
editing/pasteboard/paste-table-cells.html
editing/pasteboard/paste-text-002.html
editing/pasteboard/paste-text-003.html
editing/pasteboard/paste-text-004.html
editing/pasteboard/paste-text-005.html
editing/pasteboard/paste-text-006.html
editing/pasteboard/paste-text-007.html
editing/pasteboard/paste-text-009.html
editing/pasteboard/paste-text-010.html
editing/pasteboard/paste-text-011.html
editing/pasteboard/paste-text-012.html
editing/pasteboard/paste-text-013.html
editing/pasteboard/paste-text-014.html
editing/pasteboard/paste-text-015.html
editing/pasteboard/paste-text-016.html
editing/pasteboard/paste-text-017.html
editing/pasteboard/paste-text-018.html
editing/pasteboard/paste-text-019.html
editing/pasteboard/paste-text-at-tabspan-001.html
editing/pasteboard/paste-text-at-tabspan-002.html
editing/pasteboard/paste-text-at-tabspan-003.html
editing/pasteboard/paste-unrendered-select.html
editing/pasteboard/pasting-object.html
editing/pasteboard/prevent-block-nesting-01.html
editing/pasteboard/quirks-mode-br-1.html
editing/pasteboard/select-element-1.html
editing/pasteboard/styled-element-markup.html
editing/pasteboard/testcase-9507.html
editing/pasteboard/undoable-fragment-removes.html
editing/pasteboard/unrendered-br.html

[Robert Hogan]

Created attachment 54879 [details]
Result diffs (against Mac) of all tests to unskip

This is large pretty diff against Mac expected results of all tests that will be unskipped. It takes a while to load but should allow reviewer or anyone else to sense-check the tests that are getting unskipped.

[Robert Hogan]

Created attachment 54880 [details]
Patch

[Robert Hogan]

Created attachment 54883 [details]
Patch

The following test was incorrectly unskipped: editing/pasteboard/4806874.html
The following tests were listed in the log as unskipped when they weren't: 
editing/pasteboard/nested-blocks-with-text-area.html
editing/pasteboard/nested-blocks-with-text-field.html

[Robert Hogan]

Created attachment 54884 [details]
Result diffs (against Mac) of all tests to unskip

Diffs for the following tests were incorrectly included:

editing/pasteboard/nested-blocks-with-text-area.html
editing/pasteboard/nested-blocks-with-text-field.html

[Eric Seidel (no email)]

Comment on attachment 54883 [details]
Patch

Sad.  But so long as you unbreak the bot immediately, this looks OK.

[Csaba Osztrogonác]

Created attachment 54913 [details]
Qt specific expected files - unreviewed patch

Qt specific expected files for 54883-Patch.

Robert, I tested your patch here against Mac results, it works 
correctly. I generated the Qt specific expected files patch. 
Could you land it with your patch together?

One little question: Have you got any idea why differs the size 
of TAB in editing/pasteboard/paste-text-at-tabspan-*.html tests?
--- LayoutTests/platform/mac/editing/pasteboard/paste-text-at-tabspan-001-expected.txt  2010-04-01 07:11:23.000000000 -0700
+++ LayoutTests/platform/qt/editing/pasteboard/paste-text-at-tabspan-001-expected.txt   2010-05-03 03:21:37.000000000 -0700
-              text run at (48,14) width 110: "\x{9}\x{9}\x{9}"
+              text run at (52,14) width 21: "\x{9}\x{9}\x{9}"

Note: There are some strange thing in my patch caused by out-dated
Qt specific expected files. Diffs between Mac and new Qt results are
nicer, there are only metrics differences, as Robert said.

[Kenneth Rohde Christiansen]

Robert, are you going to land this ? :-)

[Robert Hogan]

(In reply to comment #7)
> Robert, are you going to land this ? :-)

Landed as r58675. Closing bug. (I am the bot, honest.)