Add the infrastructure to handle the executable bit. We need to implement to parsing of the file mode information in a separate patch.
Created attachment 54856 [details] Patch No functionality was changed, so no new tests. This patch is part of a coordinated effort with Chris Jerdonek to implement support of the executable bit property.
Created attachment 54857 [details] Patch Updated patch.
(In reply to comment #2) > Created an attachment (id=54857) [details] > +++ WebKitTools/Scripts/VCSUtils.pm (working copy) > +sub toggleExecutableBit > +{ > + my ($path, $executableBitDelta) = @_; I would rename this to something like "scmToggleExecutableBit" to indicate that this method is setting the executable bit in the source control sense. Also, I would document that this method does not error out if the file corresponding to $path does not exist. > +++ WebKitTools/Scripts/svn-apply (working copy) > + if (!$addition && !$deletion && !$isBinary && !$isGitBinary && !defined($diffHashRef->{executableBitDelta})) { Should you leave this line unchanged to allow the patch to apply? > +++ WebKitTools/Scripts/svn-unapply (working copy) > + if (!$addition && !$deletion && !$isBinary && !defined($diffHashRef->{executableBitDelta})) { Should you leave this line unchanged to allow the patch to apply?
Created attachment 54858 [details] Patch Corrected patch to work when the patch describes modifications to existing files.
Created attachment 54859 [details] Patch Updated patch based on Chris's suggestions.
Comment on attachment 54859 [details] Patch As we discussed, LGTM.
Comment on attachment 54859 [details] Patch Clearing flags on attachment: 54859 Committed r58637: <http://trac.webkit.org/changeset/58637>
All reviewed patches have been landed. Closing bug.