Bug 38413 - Add callback based API to get the textual representation of the RenderTree
Summary: Add callback based API to get the textual representation of the RenderTree
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC OS X 10.5
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-04-30 17:11 PDT by Sam Weinig
Modified: 2010-04-30 17:30 PDT (History)
1 user (show)

See Also:

Attachments
patch (30.80 KB, patch)
2010-04-30 17:15 PDT, Sam Weinig 		andersca: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Sam Weinig 2010-04-30 17:11:01 PDT 
Add callback based API to get the textual representation of the RenderTree, useful for implementing DRT.
Comment 1 Sam Weinig 2010-04-30 17:15:23 PDT 
Created attachment 54837 [details]
patch
Comment 2 WebKit Review Bot 2010-04-30 17:17:17 PDT 
Attachment 54837 [details] did not pass style-queue:

Failed to run "['WebKitTools/Scripts/check-webkit-style', '--no-squash']" exit_code: 1
WebKit2/UIProcess/API/C/WKPage.cpp:132:  WKPageRunJavaScriptInMainFrame_f is incorrectly named. Don't use underscores in your identifier names.  [readability/naming] [4]
WebKit2/UIProcess/API/C/WKPage.cpp:157:  WKPageRenderTreeExternalRepresentation_f is incorrectly named. Don't use underscores in your identifier names.  [readability/naming] [4]
WebKit2/UIProcess/RenderTreeExternalRepresentationCallback.h:34:  Code inside a namespace should not be indented.  [whitespace/indent] [4]
WebKit2/UIProcess/RenderTreeExternalRepresentationCallback.cpp:26:  Found header this file implements before WebCore config.h. Should be: config.h, primary header, blank line, and then alphabetically sorted.  [build/include_order] [4]
WebKit2/UIProcess/ScriptReturnValueCallback.h:34:  Code inside a namespace should not be indented.  [whitespace/indent] [4]
Total errors found: 5 in 14 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 Anders Carlsson 2010-04-30 17:21:05 PDT 
Comment on attachment 54837 [details]
patch

r=me
Comment 4 Sam Weinig 2010-04-30 17:30:37 PDT 
Fixed in r58624.