RESOLVED FIXED Bug 38413
Add callback based API to get the textual representation of the RenderTree 
https://bugs.webkit.org/show_bug.cgi?id=38413
Summary Add callback based API to get the textual representation of the RenderTree
Sam Weinig
Reported 2010-04-30 17:11:01 PDT
Add callback based API to get the textual representation of the RenderTree, useful for implementing DRT.
Attachments
patch (30.80 KB, patch)
2010-04-30 17:15 PDT, Sam Weinig 		andersca: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Sam Weinig
Comment 1 2010-04-30 17:15:23 PDT
Created attachment 54837 [details] patch
WebKit Review Bot
Comment 2 2010-04-30 17:17:17 PDT
Attachment 54837 [details] did not pass style-queue: Failed to run "['WebKitTools/Scripts/check-webkit-style', '--no-squash']" exit_code: 1 WebKit2/UIProcess/API/C/WKPage.cpp:132: WKPageRunJavaScriptInMainFrame_f is incorrectly named. Don't use underscores in your identifier names. [readability/naming] [4] WebKit2/UIProcess/API/C/WKPage.cpp:157: WKPageRenderTreeExternalRepresentation_f is incorrectly named. Don't use underscores in your identifier names. [readability/naming] [4] WebKit2/UIProcess/RenderTreeExternalRepresentationCallback.h:34: Code inside a namespace should not be indented. [whitespace/indent] [4] WebKit2/UIProcess/RenderTreeExternalRepresentationCallback.cpp:26: Found header this file implements before WebCore config.h. Should be: config.h, primary header, blank line, and then alphabetically sorted. [build/include_order] [4] WebKit2/UIProcess/ScriptReturnValueCallback.h:34: Code inside a namespace should not be indented. [whitespace/indent] [4] Total errors found: 5 in 14 files If any of these errors are false positives, please file a bug against check-webkit-style.
Anders Carlsson
Comment 3 2010-04-30 17:21:05 PDT
Comment on attachment 54837 [details] patch r=me
Sam Weinig
Comment 4 2010-04-30 17:30:37 PDT
Fixed in r58624.
Note You need to log in before you can comment on or make changes to this bug.