WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
Bug 38385
REGRESSION: RenderPath does not handle repaints correctly anymore if bounds changed
https://bugs.webkit.org/show_bug.cgi?id=38385
Summary
REGRESSION: RenderPath does not handle repaints correctly anymore if bounds c...
Nikolas Zimmermann
Reported
2010-04-30 03:57:45 PDT
Unfortunately we're still missing a good testcase, if the bounds of an object change from "bigger" to "smaller", eg. changing the stroke-width of an rect from 20 to 1. So this regression was not noticed. I have a fix with a testcase that's broken on trunk and fixed with my patch. As side effect the caching of the repaint/object/stroke bounds is simplified - we even save a FloatRect per RenderPath. Overall this is another huge performance benefit :-)
Attachments
Initial patch
(48.47 KB, patch)
2010-04-30 04:11 PDT
,
Nikolas Zimmermann
krit
: review+
Details
Formatted Diff
Diff
View All
Add attachment
proposed patch, testcase, etc.
Nikolas Zimmermann
Comment 1
2010-04-30 04:11:42 PDT
Created
attachment 54791
[details]
Initial patch
Dirk Schulze
Comment 2
2010-04-30 04:20:49 PDT
Comment on
attachment 54791
[details]
Initial patch Great Patch, like always :-) r=me
Nikolas Zimmermann
Comment 3
2010-04-30 04:23:33 PDT
Landed in
r58570
.
WebKit Review Bot
Comment 4
2010-04-30 05:11:52 PDT
http://trac.webkit.org/changeset/58570
might have broken GTK Linux 64-bit Release
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug