Bug 38385 - REGRESSION: RenderPath does not handle repaints correctly anymore if bounds changed
Summary: REGRESSION: RenderPath does not handle repaints correctly anymore if bounds c...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: SVG (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P1 Normal
Assignee: Nikolas Zimmermann
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-04-30 03:57 PDT by Nikolas Zimmermann
Modified: 2010-04-30 05:11 PDT (History)
6 users (show)

See Also:

Attachments
Initial patch (48.47 KB, patch)
2010-04-30 04:11 PDT, Nikolas Zimmermann 		krit: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Nikolas Zimmermann 2010-04-30 03:57:45 PDT 
Unfortunately we're still missing a good testcase, if the bounds of an object change from "bigger" to "smaller", eg. changing the stroke-width of an rect from 20 to 1.
So this regression was not noticed. I have a fix with a testcase that's broken on trunk and fixed with my patch.

As side effect the caching of the repaint/object/stroke bounds is simplified - we even save a FloatRect per RenderPath.
Overall this is another huge performance benefit :-)
Comment 1 Nikolas Zimmermann 2010-04-30 04:11:42 PDT 
Created attachment 54791 [details]
Initial patch
Comment 2 Dirk Schulze 2010-04-30 04:20:49 PDT 
Comment on attachment 54791 [details]
Initial patch

Great Patch, like always :-) r=me
Comment 3 Nikolas Zimmermann 2010-04-30 04:23:33 PDT 
Landed in r58570.
Comment 4 WebKit Review Bot 2010-04-30 05:11:52 PDT 
http://trac.webkit.org/changeset/58570 might have broken GTK Linux 64-bit Release