Bug 38382 - [Qt] Build error in GraphicsContext3DQt.cpp
Summary: [Qt] Build error in GraphicsContext3DQt.cpp
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit Qt (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC All
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-04-30 02:02 PDT by Jarkko Sakkinen
Modified: 2010-05-02 05:05 PDT (History)
2 users (show)

See Also:

Attachments
Build fixes. (3.11 KB, patch)
2010-04-30 02:33 PDT, Jarkko Sakkinen 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Jarkko Sakkinen 2010-04-30 02:02:49 PDT 
- Noam made duplicate patch on isGLES2Compliant. After little thinking I think his patch does this in correct way and mine does in a wrong. Have to remove my implementation.
- texImage2D/texSubImage2D API has been changed.
Comment 1 Jarkko Sakkinen 2010-04-30 02:03:48 PDT 
Noam, I'm submitting patch for this ASAP.
Comment 2 Noam Rosenthal 2010-04-30 02:06:52 PDT 
Thanks Jarkko... I guess we had a mid-air collision on this :)
Comment 3 Jarkko Sakkinen 2010-04-30 02:33:05 PDT 
Created attachment 54789 [details]
Build fixes.
Comment 4 Jarkko Sakkinen 2010-04-30 02:33:25 PDT 
Yeah, np :)
Comment 5 Eric Seidel (no email) 2010-04-30 11:43:28 PDT 
Comment on attachment 54789 [details]
Build fixes.

LGTM.
Comment 6 WebKit Commit Bot 2010-05-02 05:05:29 PDT 
Comment on attachment 54789 [details]
Build fixes.

Clearing flags on attachment: 54789

Committed r58651: <http://trac.webkit.org/changeset/58651>
Comment 7 WebKit Commit Bot 2010-05-02 05:05:34 PDT 
All reviewed patches have been landed.  Closing bug.