Bug 38370 - [Qt] GraphicsLayer: depth-test causes flicker in certain situations
Summary: [Qt] GraphicsLayer: depth-test causes flicker in certain situations
Status: CLOSED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Layout and Rendering (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC All
: P2 Normal
Assignee: Nobody
URL: http://webkit.org/blog-files/3d-trans...
Keywords: Qt
Depends on:
Blocks: 38744
  Show dependency treegraph
 
Reported: 2010-04-29 20:32 PDT by Noam Rosenthal
Modified: 2010-05-14 01:25 PDT (History)
6 users (show)

See Also:


Attachments
Remove the simplistic depth test (1.82 KB, patch)
2010-04-29 20:36 PDT, Noam Rosenthal
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Noam Rosenthal 2010-04-29 20:32:39 PDT
the depth test for stacking items in 3D space is inaccurate - suggesting to remove it for this version.
Comment 1 Noam Rosenthal 2010-04-29 20:36:37 PDT
Created attachment 54778 [details]
Remove the simplistic depth test
Comment 2 Eric Seidel (no email) 2010-04-30 11:46:36 PDT
Comment on attachment 54778 [details]
Remove the simplistic depth test

OK.  Do we have no way to test this using repaint tests?
Comment 3 Noam Rosenthal 2010-04-30 14:33:21 PDT
Actually, now that you mention it, the tests in LayoutTests/compositing/geometry seem to test this, and some of them regressed.
This patch is still good - but I probably need a couple of more patches to fix those regressions.
Comment 4 Noam Rosenthal 2010-05-02 02:52:08 PDT
Sorry, my last comment was meant for another bug.
There's no way to test this because the depth-test functionality is not specified anywhere. The depth-test functionality is a completely platform-specific choice.
Comment 5 WebKit Commit Bot 2010-05-12 23:27:50 PDT
Comment on attachment 54778 [details]
Remove the simplistic depth test

Clearing flags on attachment: 54778

Committed r59347: <http://trac.webkit.org/changeset/59347>
Comment 6 WebKit Commit Bot 2010-05-12 23:27:57 PDT
All reviewed patches have been landed.  Closing bug.
Comment 7 Simon Hausmann 2010-05-14 01:23:41 PDT
Revision r59347 cherry-picked into qtwebkit-2.0 with commit 88ea502ee97de59515558c299272cc3420048d68