RESOLVED FIXED Bug 38363
Handle double on righthand side of a right shift 
https://bugs.webkit.org/show_bug.cgi?id=38363
Summary Handle double on righthand side of a right shift
Oliver Hunt
Reported 2010-04-29 17:10:08 PDT
Handle double on righthand side of a right shift
Attachments
Patch (3.89 KB, patch)
2010-04-29 17:14 PDT, Oliver Hunt 		no flags
DetailsFormatted DiffDiff
Patch (3.94 KB, patch)
2010-04-29 17:27 PDT, Oliver Hunt 		barraclough: review+
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Oliver Hunt
Comment 1 2010-04-29 17:14:07 PDT
Created attachment 54757 [details] Patch
Oliver Hunt
Comment 2 2010-04-29 17:27:36 PDT
Created attachment 54760 [details] Patch
Gavin Barraclough
Comment 3 2010-04-29 18:34:53 PDT
Comment on attachment 54760 [details] Patch I think the if/else cases could be a little clearer if you structured them like this: if (isOperandConstantImmediateInt(op2)) { // ... // ... (1 slow case to link), (optimization goes here!) // ... } else if (isOperandConstantImmediateInt(op1)) { // ... // ... (1 slow case to link) // ... } else { // !isOperandConstantImmediateInt(op1) && !isOperandConstantImmediateInt(op2) // ... // ... (2 slow cases to link), (optimization goes here!) // ... } buts that's personal taste, r+ either way.
Oliver Hunt
Comment 4 2010-04-29 19:50:02 PDT
Committed r58555: <http://trac.webkit.org/changeset/58555>
Note You need to log in before you can comment on or make changes to this bug.