Bug 38352 - Need to updateLayout after typing commands too
Summary: Need to updateLayout after typing commands too
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: HTML Editing (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC OS X 10.5
: P2 Normal
Assignee: Justin Garcia
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-04-29 14:33 PDT by Justin Garcia
Modified: 2010-04-29 17:51 PDT (History)
1 user (show)

See Also:


Attachments
patch (5.18 KB, patch)
2010-04-29 15:59 PDT, Justin Garcia
adele: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Justin Garcia 2010-04-29 14:33:43 PDT
In EditCommand::apply(), unapply() and reapply(), we do an updateLayout in case the editing operation doesn't do it itself.  We should provide this convenience for typing commands, too.  Text insertion is part of some open typing command, and they don't go through these functions, but all high level editing operations go through Editor::appliedEditing, unappliedEditing and reappliedEditing.  We should move the updateLayout there.
Comment 1 Justin Garcia 2010-04-29 15:59:20 PDT
Created attachment 54746 [details]
patch
Comment 2 Enrica Casucci 2010-04-29 16:39:39 PDT
Looks good to me.
Comment 3 Justin Garcia 2010-04-29 16:52:39 PDT
Comment on attachment 54746 [details]
patch

enrica r+d this over email
Comment 4 Justin Garcia 2010-04-29 16:55:20 PDT
Comment on attachment 54746 [details]
patch

Oops Enrica doesn't have r+ privs yet, resetting the review flag.
Comment 5 Adele Peterson 2010-04-29 16:59:52 PDT
Comment on attachment 54746 [details]
patch

looks fine.
Comment 6 Justin Garcia 2010-04-29 17:51:32 PDT
trac.webkit.org/projects/webkit/changeset/58551