Bug 38339 - [Qt] Enable JIT for QtWebKit on Symbian
Summary: [Qt] Enable JIT for QtWebKit on Symbian
Status: CLOSED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC S60 3rd edition
: P2 Normal
Assignee: Nobody
URL:
Keywords: Qt
Depends on:
Blocks: 35784
  Show dependency treegraph
 
Reported: 2010-04-29 12:29 PDT by Laszlo Gombos
Modified: 2010-05-05 08:19 PDT (History)
9 users (show)

See Also:


Attachments
proposed patch (1.53 KB, patch)
2010-04-29 12:39 PDT, Laszlo Gombos
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Laszlo Gombos 2010-04-29 12:29:00 PDT
It has been stable for quite some time, it is time to make it the default.
Comment 1 Laszlo Gombos 2010-04-29 12:39:18 PDT
Created attachment 54729 [details]
proposed patch
Comment 2 Eric Seidel (no email) 2010-04-30 11:53:04 PDT
Comment on attachment 54729 [details]
proposed patch

OK.  rs=me.
Comment 3 WebKit Commit Bot 2010-05-02 05:26:49 PDT
Comment on attachment 54729 [details]
proposed patch

Clearing flags on attachment: 54729

Committed r58652: <http://trac.webkit.org/changeset/58652>
Comment 4 WebKit Commit Bot 2010-05-02 05:26:55 PDT
All reviewed patches have been landed.  Closing bug.
Comment 5 WebKit Review Bot 2010-05-02 05:52:46 PDT
http://trac.webkit.org/changeset/58652 might have broken Qt Linux ARMv7 Release
Comment 6 Eric Seidel (no email) 2010-05-02 06:19:37 PDT
This broke builders and should be rolled out if the fix is not obvious. I'm sad we have cq auto-rollouts turned off at the moment.
Comment 7 Eric Seidel (no email) 2010-05-02 09:00:20 PDT
Perhaps it was a dependency problem with the Qt build system.  The failure appears to have resolved itself.
Comment 8 Csaba Osztrogonác 2010-05-02 11:53:39 PDT
(In reply to comment #7)
> Perhaps it was a dependency problem with the Qt build system.  The failure
> appears to have resolved itself.

No, there wasn't any problem with build system at this time. It was connection lost problem. I will dig a little in buildbot logs, config, etc. and try to fine tune to avoid this disappointing feature/bug.

"remoteFailed: [Failure instance: Traceback (failure with no frames): <class 'twisted.internet.error.ConnectionLost'>: Connection to the other side was lost in a non-clean fashion."
Comment 9 Simon Hausmann 2010-05-05 08:19:06 PDT
Revision r58652 cherry-picked into qtwebkit-2.0 with commit 3f701c6180f2b138e8e2bd8b29b8c9db82ee9733