Bug 38337 – CSSMatrix.multiply() method works backwards relative to SVGMatrix

• Status: RESOLVED
• Resolution: FIXED
• Component: CSS

[Chris Marrin]

Attached test case shows this behavior. It fails in TOT, but the equivalent multiply works correctly for SVGMatrix in TOT. In particular, this code:

m = new WebKitCSSMatrix("matrix(1, 2, 3, 4, 5, 6)");
m2 = new WebKitCSSMatrix("matrix(7, 8, 9, 10, 11, 12)");
var m3 = m.multiply(m2);
shouldBe('parseFloat(m3.a)', '31');
shouldBe('parseFloat(m3.b)', '46');
shouldBe('parseFloat(m3.c)', '39');
shouldBe('parseFloat(m3.d)', '58');
shouldBe('parseFloat(m3.e)', '52');
shouldBe('parseFloat(m3.f)', '76');

Fails the shouldBe tests showing that we are multiplying on the right rather than the left like SVG

[Chris Marrin]

Created attachment 54724 [details]
Testcase showing the problem

[Simon Fraser (smfr)]

See http://lists.w3.org/Archives/Public/public-fx/2010AprJun/0022.html

[Chris Marrin]

Created attachment 54725 [details]
Better testcase which doesn't need extra JS files

[Simon Fraser (smfr)]

Created attachment 54735 [details]
CSS vs. SVG testcase

[Chris Marrin]

Created attachment 54752 [details]
Patch with testcases

[Chris Marrin]

Created attachment 54754 [details]
replacement patch with test cases

[WebKit Review Bot]

Attachment 54754 [details] did not pass style-queue:

Failed to run "['WebKitTools/Scripts/check-webkit-style', '--no-squash']" exit_code: 1
LayoutTests/ChangeLog:30:  Line contains tab character.  [whitespace/tab] [5]
LayoutTests/ChangeLog:31:  Line contains tab character.  [whitespace/tab] [5]
LayoutTests/ChangeLog:33:  Line contains tab character.  [whitespace/tab] [5]
LayoutTests/ChangeLog:35:  Line contains tab character.  [whitespace/tab] [5]
Total errors found: 4 in 13 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[Chris Marrin]

Created attachment 54808 [details]
Fixed new test case so pixel results don't cutoff some of the image

[Chris Marrin]

Landed in http://trac.webkit.org/changeset/58584

[WebKit Review Bot]

http://trac.webkit.org/changeset/58584 might have broken GTK Linux 32-bit Release

[Simon Fraser (smfr)]

See bug 38953.