Allow other ports to compile ATSUI and CoreText functions in SimpleFontData for Mac.
Created attachment 54719 [details]
This is needed so that wx can compile and use ComplexTextController, BTW.
Comment on attachment 54719 [details]
This should be done by svn cp’ing SimpleFontDataMac.mm to the two new files and removing everything but the needed methods, includes and copyright headers. The #if USE()s should go outside the namespace and the second paragraph of #includes.
Created attachment 54747 [details]
Attachment 54747 [details] did not pass style-queue:
Failed to run "['WebKitTools/Scripts/check-webkit-style', '--no-squash']" exit_code: 1
WebCore/platform/graphics/mac/SimpleFontDataCoreText.cpp:48: Use 0 instead of NULL. [readability/null] 
WebCore/platform/graphics/mac/SimpleFontDataCoreText.cpp:74: Use 0 instead of NULL. [readability/null] 
WebCore/platform/graphics/mac/SimpleFontDataCoreText.cpp:81: Use 0 instead of NULL. [readability/null] 
Total errors found: 3 in 4 files
If any of these errors are false positives, please file a bug against check-webkit-style.
Comment on attachment 54747 [details]
Is there a reason why you didn’t address my second feedback item, regarding the placement of the #if directives?
Created attachment 54749 [details]
(In reply to comment #6)
> (From update of attachment 54747 [details])
> Is there a reason why you didn’t address my second feedback item, regarding the
> placement of the #if directives?
Oops, sorry, no, I just got caught up in redoing the patch and forgot about it. I'll fix and re-upload.
Created attachment 54751 [details]
The patch was committed as r58557, and rolled out by r58560 because of compile errors on Tiger, Leopard, and Chromium/Mac.
(In reply to comment #10)
> The patch was committed as r58557, and rolled out by r58560 because of compile
> errors on Tiger, Leopard, and Chromium/Mac.
Correction: Tiger was ok. Leopard and Chromium/Mac failed.
I haven't looked into the compile failures but FYI Chromium compiles with both the ATSUI & Core text functionality enabled and switches the APIs used at runtime. This, as opposed to other ports that make the decision at compile time.
http://trac.webkit.org/changeset/58581 might have broken Chromium Mac Release
Landed in r58581, with Chromium build fix in r58582.