Bug 38322 - Web Inspector: Timeline panel is not refreshing.
Summary: Web Inspector: Timeline panel is not refreshing.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (Deprecated) (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-04-29 06:16 PDT by Ilya Tikhonovsky
Modified: 2010-04-29 11:13 PDT (History)
4 users (show)

See Also:


Attachments
[patch] initial version. (3.42 KB, patch)
2010-04-29 06:35 PDT, Ilya Tikhonovsky
yurys: review+
Details | Formatted Diff | Diff
[patch] second iteration. (3.43 KB, patch)
2010-04-29 07:22 PDT, Ilya Tikhonovsky
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Ilya Tikhonovsky 2010-04-29 06:16:47 PDT
a) If Timeline panel is in recording mode and is not visible and some events have arrived then it will not refresh when it becomes visible.
Use case:
1) switch to timeline panel;
2) start recording;
3) switch to resource panel;
4) force reload of inspected page;
5) switch back to timeline panel;
6) You will see crystal clear panel in recording state. The records will appear if you change filters.

b) timeline popup can appear at up-left corner when you switched to some other panel.
Comment 1 Ilya Tikhonovsky 2010-04-29 06:35:19 PDT
Created attachment 54695 [details]
[patch] initial version.
Comment 2 Yury Semikhatsky 2010-04-29 07:03:59 PDT
Comment on attachment 54695 [details]
[patch] initial version.

WebCore/inspector/front-end/TimelinePanel.js:413
 +              if (!("_refreshTimeout" in this))
simple "if (!this._refreshTimeout)" should work
Comment 3 Ilya Tikhonovsky 2010-04-29 07:22:37 PDT
Created attachment 54702 [details]
[patch] second iteration.

style changes
Comment 4 WebKit Commit Bot 2010-04-29 07:36:58 PDT
Comment on attachment 54702 [details]
[patch] second iteration.

Rejecting patch 54702 from review queue.

loislo@chromium.org does not have reviewer permissions according to http://trac.webkit.org/browser/trunk/WebKitTools/Scripts/webkitpy/common/config/committers.py.

- If you do not have reviewer rights please read http://webkit.org/coding/contributing.html for instructions on how to use bugzilla flags.

- If you have reviewer rights please correct the error in WebKitTools/Scripts/webkitpy/common/config/committers.py by adding yourself to the file (no review needed).  Due to bug 30084 the commit-queue will require a restart after your change.  Please contact eseidel@chromium.org to request a commit-queue restart.  After restart the commit-queue will correctly respect your reviewer rights.
Comment 5 WebKit Commit Bot 2010-04-29 11:12:56 PDT
Comment on attachment 54702 [details]
[patch] second iteration.

Clearing flags on attachment: 54702

Committed r58528: <http://trac.webkit.org/changeset/58528>
Comment 6 WebKit Commit Bot 2010-04-29 11:13:01 PDT
All reviewed patches have been landed.  Closing bug.