Bug 38322 – Web Inspector: Timeline panel is not refreshing.

• Status: RESOLVED
• Resolution: FIXED
• Component: Web Inspector (Deprecated)

[Ilya Tikhonovsky]

a) If Timeline panel is in recording mode and is not visible and some events have arrived then it will not refresh when it becomes visible.
Use case:
1) switch to timeline panel;
2) start recording;
3) switch to resource panel;
4) force reload of inspected page;
5) switch back to timeline panel;
6) You will see crystal clear panel in recording state. The records will appear if you change filters.

b) timeline popup can appear at up-left corner when you switched to some other panel.

[Ilya Tikhonovsky]

Created attachment 54695 [details]
[patch] initial version.

[Yury Semikhatsky]

Comment on attachment 54695 [details]
[patch] initial version.

WebCore/inspector/front-end/TimelinePanel.js:413
 +              if (!("_refreshTimeout" in this))
simple "if (!this._refreshTimeout)" should work

[Ilya Tikhonovsky]

Created attachment 54702 [details]
[patch] second iteration.

style changes

[WebKit Commit Bot]

Comment on attachment 54702 [details]
[patch] second iteration.

Rejecting patch 54702 from review queue.

[e-mail] does not have reviewer permissions according to http://trac.webkit.org/browser/trunk/WebKitTools/Scripts/webkitpy/common/config/committers.py.

- If you do not have reviewer rights please read http://webkit.org/coding/contributing.html for instructions on how to use bugzilla flags.

- If you have reviewer rights please correct the error in WebKitTools/Scripts/webkitpy/common/config/committers.py by adding yourself to the file (no review needed).  Due to bug 30084 the commit-queue will require a restart after your change.  Please contact [e-mail] to request a commit-queue restart.  After restart the commit-queue will correctly respect your reviewer rights.

[WebKit Commit Bot]

Comment on attachment 54702 [details]
[patch] second iteration.

Clearing flags on attachment: 54702

Committed r58528: <http://trac.webkit.org/changeset/58528>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.