Bug 38312 - Add sqrt support for ARM port
Summary: Add sqrt support for ARM port
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Enhancement
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-04-29 00:57 PDT by Zoltan Herczeg
Modified: 2010-05-06 23:25 PDT (History)
5 users (show)

See Also:


Attachments
patch (2.95 KB, patch)
2010-04-29 01:03 PDT, Zoltan Herczeg
oliver: review+
commit-queue: commit-queue-
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Zoltan Herczeg 2010-04-29 00:57:14 PDT
Patch for sqrt support
Comment 1 Zoltan Herczeg 2010-04-29 01:03:35 PDT
Created attachment 54680 [details]
patch
Comment 2 WebKit Review Bot 2010-04-29 01:04:58 PDT
Attachment 54680 [details] did not pass style-queue:

Failed to run "['WebKitTools/Scripts/check-webkit-style', '--no-squash']" exit_code: 1
JavaScriptCore/assembler/ARMAssembler.h:430:  fsqrtd_r is incorrectly named. Don't use underscores in your identifier names.  [readability/naming] [4]
Total errors found: 1 in 3 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 WebKit Commit Bot 2010-04-29 06:42:32 PDT
Comment on attachment 54680 [details]
patch

Rejecting patch 54680 from commit-queue.

Found no modified ChangeLogs, cannot create a commit message.
All changes require a ChangeLog.  See:
http://webkit.org/coding/contributing.html
Comment 4 Zoltan Herczeg 2010-04-29 07:54:40 PDT
> Found no modified ChangeLogs, cannot create a commit message.

There IS a ChangeLog in the patch, bot.

Anyway, landed in r58515
Comment 5 Eric Seidel (no email) 2010-04-29 08:38:24 PDT
I suspect there may be an error in the date line.  Webkit-patch commit-message can tell you.
Comment 6 Eric Seidel (no email) 2010-05-06 23:25:56 PDT
Turns out there was a regression in svn-apply.  cjersonek fixed.