WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
38311
Remove custom bindings for PopStateEvent.initPopStateEvent
https://bugs.webkit.org/show_bug.cgi?id=38311
Summary
Remove custom bindings for PopStateEvent.initPopStateEvent
Adam Barth
Reported
2010-04-28 22:23:08 PDT
Remove custom bindings for PopStateEvent.initPopStateEvent
Attachments
Patch
(17.77 KB, patch)
2010-04-28 22:25 PDT
,
Adam Barth
no flags
Details
Formatted Diff
Diff
Patch
(17.51 KB, patch)
2010-04-28 22:50 PDT
,
Adam Barth
no flags
Details
Formatted Diff
Diff
Show Obsolete
(1)
View All
Add attachment
proposed patch, testcase, etc.
Adam Barth
Comment 1
2010-04-28 22:25:26 PDT
Created
attachment 54675
[details]
Patch
WebKit Review Bot
Comment 2
2010-04-28 22:27:28 PDT
Attachment 54675
[details]
did not pass style-queue: Failed to run "['WebKitTools/Scripts/check-webkit-style', '--no-squash']" exit_code: 1 WebCore/bindings/scripts/test/GObject/WebKitDOMTestObj.cpp:129: Extra space before ( in function call [whitespace/parens] [4] WebCore/bindings/scripts/test/GObject/WebKitDOMTestObj.cpp:131: Extra space before ( in function call [whitespace/parens] [4] WebCore/bindings/scripts/test/GObject/WebKitDOMTestObj.cpp:133: Extra space before ( in function call [whitespace/parens] [4] WebCore/bindings/scripts/test/GObject/WebKitDOMTestObj.cpp:134: _g_serialized_arg is incorrectly named. Don't use underscores in your identifier names. [readability/naming] [4] WebCore/bindings/scripts/test/GObject/WebKitDOMTestObj.cpp:135: Extra space before ( in function call [whitespace/parens] [4] WebCore/bindings/scripts/test/JS/JSTestObj.cpp:143: Missing spaces around | [whitespace/operators] [3] WebCore/bindings/scripts/test/GObject/WebKitDOMTestObj.h:68: Extra space before ( in function call [whitespace/parens] [4] Total errors found: 7 in 13 files If any of these errors are false positives, please file a bug against check-webkit-style.
Adam Barth
Comment 3
2010-04-28 22:45:40 PDT
Comment on
attachment 54675
[details]
Patch V8 problem. One sec.
WebKit Review Bot
Comment 4
2010-04-28 22:47:07 PDT
Attachment 54675
[details]
did not build on chromium: Build output:
http://webkit-commit-queue.appspot.com/results/1855176
Adam Barth
Comment 5
2010-04-28 22:50:32 PDT
Created
attachment 54677
[details]
Patch
WebKit Review Bot
Comment 6
2010-04-28 22:57:52 PDT
Attachment 54677
[details]
did not pass style-queue: Failed to run "['WebKitTools/Scripts/check-webkit-style', '--no-squash']" exit_code: 1 WebCore/bindings/scripts/test/GObject/WebKitDOMTestObj.cpp:129: Extra space before ( in function call [whitespace/parens] [4] WebCore/bindings/scripts/test/GObject/WebKitDOMTestObj.cpp:131: Extra space before ( in function call [whitespace/parens] [4] WebCore/bindings/scripts/test/GObject/WebKitDOMTestObj.cpp:133: Extra space before ( in function call [whitespace/parens] [4] WebCore/bindings/scripts/test/GObject/WebKitDOMTestObj.cpp:134: _g_serialized_arg is incorrectly named. Don't use underscores in your identifier names. [readability/naming] [4] WebCore/bindings/scripts/test/GObject/WebKitDOMTestObj.cpp:135: Extra space before ( in function call [whitespace/parens] [4] WebCore/bindings/scripts/test/JS/JSTestObj.cpp:143: Missing spaces around | [whitespace/operators] [3] WebCore/bindings/scripts/test/GObject/WebKitDOMTestObj.h:68: Extra space before ( in function call [whitespace/parens] [4] Total errors found: 7 in 13 files If any of these errors are false positives, please file a bug against check-webkit-style.
Maciej Stachowiak
Comment 7
2010-04-28 23:56:18 PDT
Comment on
attachment 54677
[details]
Patch r=me I took on faith that the code generated for v8 is right.
WebKit Commit Bot
Comment 8
2010-04-29 04:46:43 PDT
Comment on
attachment 54677
[details]
Patch Clearing flags on attachment: 54677 Committed
r58504
: <
http://trac.webkit.org/changeset/58504
>
WebKit Commit Bot
Comment 9
2010-04-29 04:46:49 PDT
All reviewed patches have been landed. Closing bug.
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug