Bug 38288 - [chromium] revert getFontDataForCharacters change in r58341
Summary: [chromium] revert getFontDataForCharacters change in r58341
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Other OS X 10.5
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-04-28 15:24 PDT by Evan Martin
Modified: 2010-04-28 17:38 PDT (History)
1 user (show)

See Also:

Attachments
Patch (4.62 KB, patch)
2010-04-28 15:26 PDT, Evan Martin 		levin: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Evan Martin 2010-04-28 15:24:42 PDT 
[chromium] revert getFontDataForCharacters change
Comment 1 Evan Martin 2010-04-28 15:26:32 PDT 
Created attachment 54629 [details]
Patch
Comment 2 Evan Martin 2010-04-28 15:28:25 PDT 
We hit this code path repeatedly while rendering.  It wasn't so bad before (since it was just computing a font name) but it is very bad now (since we're loading a font).
Comment 3 Adam Langley 2010-04-28 15:32:36 PDT 
LGTM.

(I think a rollout is permitted without a real WebKit review so you could just land this now.)
Comment 4 Evan Martin 2010-04-28 17:38:47 PDT 
Committed r58447: <http://trac.webkit.org/changeset/58447>