WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
38284
Audit all uses of subprocess in webkitpy
https://bugs.webkit.org/show_bug.cgi?id=38284
Summary
Audit all uses of subprocess in webkitpy
Eric Seidel (no email)
Reported
2010-04-28 14:24:15 PDT
Audit all uses of subprocess in webkitpy
Attachments
Patch
(10.50 KB, patch)
2010-04-28 14:28 PDT
,
Eric Seidel (no email)
no flags
Details
Formatted Diff
Diff
Now with a unittest
(12.81 KB, patch)
2010-04-28 14:46 PDT
,
Eric Seidel (no email)
levin
: review+
levin
: commit-queue+
Details
Formatted Diff
Diff
Show Obsolete
(1)
View All
Add attachment
proposed patch, testcase, etc.
Eric Seidel (no email)
Comment 1
2010-04-28 14:28:25 PDT
Created
attachment 54621
[details]
Patch
David Levin
Comment 2
2010-04-28 14:38:53 PDT
Comment on
attachment 54621
[details]
Patch Two things to fix up before committing.
> diff --git a/WebKitTools/ChangeLog b/WebKitTools/ChangeLog > + in webkitpy. I did not find any unsafe calls > + in my audit, but I did remove numerousunneeded
numerousunneeded >
> diff --git a/WebKitTools/Scripts/webkitpy/layout_tests/port/chromium_mac.py b/WebKitTools/Scripts/webkitpy/layout_tests/port/chromium_mac.py
> - rcode = subprocess.call(['wdiff'], stderr=f) > + # We're ignoring the return and always returning True > + self._executive.run_command(['wdiff'], error_handler=Excutive.ignore_error)
Excutive You mentioned possibly adding a test for this? It may be good if you could because it would have caught this issue.
Eric Seidel (no email)
Comment 3
2010-04-28 14:46:09 PDT
Created
attachment 54624
[details]
Now with a unittest
Eric Seidel (no email)
Comment 4
2010-04-28 14:52:21 PDT
Committed
r58434
: <
http://trac.webkit.org/changeset/58434
>
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug