Bug 3828 - GW: add QTime::addMSecs() suppport and currentTime() support to KWQ
Summary: GW: add QTime::addMSecs() suppport and currentTime() support to KWQ
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 420+
Hardware: Mac OS X 10.4
: P4 Enhancement
Assignee: Eric Seidel (no email)
URL:
Keywords:
Depends on:
Blocks: 3250
  Show dependency tree / graph
 
Reported: 2005-07-02 20:40 PDT by Eric Seidel (no email)
Modified: 2005-07-05 01:18 PDT (History)
0 users

See Also:

Attachments
self explanitory patch. (1.29 KB, patch)
2005-07-02 20:40 PDT, Eric Seidel (no email) 		mjs: review-
Details | Formatted Diff | Diff
Fixes mjs's concern (1.25 KB, patch)
2005-07-04 01:10 PDT, Eric Seidel (no email) 		mjs: review+
Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Eric Seidel (no email) 2005-07-02 20:40:14 PDT 
Simple patch, adds QTime::addMSecs() suppport and currentTime() support to KWQ
Comment 1 Eric Seidel (no email) 2005-07-02 20:40:47 PDT 
Created attachment 2767 [details]
self explanitory patch.
Comment 2 Maciej Stachowiak 2005-07-03 03:02:53 PDT 
Comment on attachment 2767 [details]
self explanitory patch.

This appears buggy. It seems to add msecs to the default time rather than the
current time.  One way around this would be to copy-construct QTime from *this,
and since the default time value is 0 this is quite likely wrong.
Comment 3 Maciej Stachowiak 2005-07-03 03:03:30 PDT 
Oops, my comment got a little garbled, hope it still makes sense.
Comment 4 Eric Seidel (no email) 2005-07-04 01:10:19 PDT 
Created attachment 2781 [details]
Fixes mjs's concern