Bug 38266 - Chromium: breakpoints do not work.
Summary: Chromium: breakpoints do not work.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (Deprecated) (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-04-28 09:53 PDT by Andrey Kosyakov
Modified: 2010-04-28 10:14 PDT (History)
2 users (show)

See Also:

Attachments
patch: fixed parameter passing to DebuggerAgent.addBreakpoint() (1.25 KB, patch)
2010-04-28 10:00 PDT, Andrey Kosyakov 		pfeldman: review+
pfeldman: commit-queue+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Andrey Kosyakov 2010-04-28 09:53:22 PDT 
https://bugs.webkit.org/show_bug.cgi?id=38132 broke breakpoints in Chromium due to InspectorControllerImpl.js missing from patch.
Comment 1 Andrey Kosyakov 2010-04-28 10:00:43 PDT 
Created attachment 54575 [details]
patch: fixed parameter passing to DebuggerAgent.addBreakpoint()
Comment 2 Pavel Feldman 2010-04-28 10:10:37 PDT 
Committing to http://svn.webkit.org/repository/webkit/trunk ...
	M	WebCore/ChangeLog
	M	WebCore/bindings/js/ScriptEventListener.cpp
	M	WebCore/bindings/js/ScriptEventListener.h
	M	WebCore/bindings/v8/ScriptEventListener.cpp
	M	WebCore/bindings/v8/ScriptEventListener.h
	M	WebCore/inspector/InspectorDOMAgent.cpp
	M	WebCore/inspector/front-end/ElementsPanel.js
	M	WebCore/inspector/front-end/EventListenersSidebarPane.js
	M	WebCore/inspector/front-end/StylesSidebarPane.js
	M	WebCore/inspector/front-end/inspector.css
Committed r58412
Comment 3 Pavel Feldman 2010-04-28 10:11:04 PDT 
Oops. Wrong bug.
Comment 4 Pavel Feldman 2010-04-28 10:14:54 PDT 
Committing to http://svn.webkit.org/repository/webkit/trunk ...
	M	WebKit/chromium/ChangeLog
	M	WebKit/chromium/src/js/InspectorControllerImpl.js
Committed r58413