Bug 3826 - GW: Add defs to KWQDefs
Summary: GW: Add defs to KWQDefs
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 420+
Hardware: Mac OS X 10.4
: P4 Enhancement
Assignee: Eric Seidel (no email)
URL:
Keywords:
Depends on:
Blocks: 3250
  Show dependency treegraph
 
Reported: 2005-07-02 20:34 PDT by Eric Seidel (no email)
Modified: 2005-07-07 00:32 PDT (History)
0 users

See Also:


Attachments
Adds a few defs to KWQDefs (1.17 KB, patch)
2005-07-02 20:36 PDT, Eric Seidel (no email)
mjs: review-
Details | Formatted Diff | Diff
fixes mjs's concerns (896 bytes, patch)
2005-07-04 01:14 PDT, Eric Seidel (no email)
ggaren: review-
Details | Formatted Diff | Diff
patch to fix failed build (897 bytes, patch)
2005-07-05 11:20 PDT, Geoffrey Garen
no flags Details | Formatted Diff | Diff
patch that builds w/gcc 3.3 (2.32 KB, patch)
2005-07-05 13:38 PDT, Geoffrey Garen
mjs: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Eric Seidel (no email) 2005-07-02 20:34:26 PDT
These defs are necessary for compiling kdom, and other products on top of KWQ.
Comment 1 Eric Seidel (no email) 2005-07-02 20:36:02 PDT
Created attachment 2765 [details]
Adds a few defs to KWQDefs

This patch also removes the Q_UNUSED(a) hack, or at least changes the
implementation thereof.  The previous implementation did not work with unused
"const" arguments.   At least not under GCC 4.0
Comment 2 Maciej Stachowiak 2005-07-03 00:36:31 PDT
Comment on attachment 2765 [details]
Adds a few defs to KWQDefs

> +typedef __int64_t Q_INT64;
> +typedef __uint64_t Q_UINT64;

Suggest using int64_t and uint_64_t with no underscores instead.

Regarding QMAX/QMIN and KMAX/KMIN, I think it would be better to port the
relevant code to kMax kMin, since that's the direction KHTML went, but failing
that, at least use the typesafe version for QMAX/QMIN.

> +#define qRound(a) lround(a)

Suggest an inline function instead of a macro.
Comment 3 Eric Seidel (no email) 2005-07-04 01:14:34 PDT
Created attachment 2783 [details]
fixes mjs's concerns
Comment 4 Maciej Stachowiak 2005-07-04 18:11:36 PDT
Comment on attachment 2783 [details]
fixes mjs's concerns

r=me
Comment 5 Geoffrey Garen 2005-07-05 11:17:48 PDT
Comment on attachment 2783 [details]
fixes mjs's concerns

this patch fails to build
Comment 6 Geoffrey Garen 2005-07-05 11:20:36 PDT
Created attachment 2819 [details]
patch to fix failed build

This patch will build successfully
Comment 7 Eric Seidel (no email) 2005-07-05 11:26:49 PDT
Comment on attachment 2783 [details]
fixes mjs's concerns

ggaren, can I get a log message, or a reason?  This patch builds for me just
fine.  I'm using gcc 4.0
Comment 8 Eric Seidel (no email) 2005-07-05 11:38:45 PDT
The build failure was only on 3.3 (which Apple internal is the only one left using).
Comment 9 Geoffrey Garen 2005-07-05 13:38:58 PDT
Created attachment 2821 [details]
patch that builds w/gcc 3.3

This version of the patch builds successfully w/gcc 3.3
Comment 10 Maciej Stachowiak 2005-07-05 18:58:46 PDT
Comment on attachment 2821 [details]
patch that builds w/gcc 3.3

r=me