RESOLVED FIXED 3826
GW: Add defs to KWQDefs 
https://bugs.webkit.org/show_bug.cgi?id=3826
Summary GW: Add defs to KWQDefs
Eric Seidel (no email)
Reported 2005-07-02 20:34:26 PDT
These defs are necessary for compiling kdom, and other products on top of KWQ.
Attachments
Adds a few defs to KWQDefs (1.17 KB, patch)
2005-07-02 20:36 PDT, Eric Seidel (no email) 		mjs: review-
DetailsFormatted DiffDiff
fixes mjs's concerns (896 bytes, patch)
2005-07-04 01:14 PDT, Eric Seidel (no email) 		ggaren: review-
DetailsFormatted DiffDiff
patch to fix failed build (897 bytes, patch)
2005-07-05 11:20 PDT, Geoffrey Garen 		no flags
DetailsFormatted DiffDiff
patch that builds w/gcc 3.3 (2.32 KB, patch)
2005-07-05 13:38 PDT, Geoffrey Garen 		mjs: review+
DetailsFormatted DiffDiff
Show Obsolete (3) View All Add attachment proposed patch, testcase, etc.
Eric Seidel (no email)
Comment 1 2005-07-02 20:36:02 PDT
Created attachment 2765 [details] Adds a few defs to KWQDefs This patch also removes the Q_UNUSED(a) hack, or at least changes the implementation thereof. The previous implementation did not work with unused "const" arguments. At least not under GCC 4.0
Maciej Stachowiak
Comment 2 2005-07-03 00:36:31 PDT
Comment on attachment 2765 [details] Adds a few defs to KWQDefs > +typedef __int64_t Q_INT64; > +typedef __uint64_t Q_UINT64; Suggest using int64_t and uint_64_t with no underscores instead. Regarding QMAX/QMIN and KMAX/KMIN, I think it would be better to port the relevant code to kMax kMin, since that's the direction KHTML went, but failing that, at least use the typesafe version for QMAX/QMIN. > +#define qRound(a) lround(a) Suggest an inline function instead of a macro.
Eric Seidel (no email)
Comment 3 2005-07-04 01:14:34 PDT
Created attachment 2783 [details] fixes mjs's concerns
Maciej Stachowiak
Comment 4 2005-07-04 18:11:36 PDT
Comment on attachment 2783 [details] fixes mjs's concerns r=me
Geoffrey Garen
Comment 5 2005-07-05 11:17:48 PDT
Comment on attachment 2783 [details] fixes mjs's concerns this patch fails to build
Geoffrey Garen
Comment 6 2005-07-05 11:20:36 PDT
Created attachment 2819 [details] patch to fix failed build This patch will build successfully
Eric Seidel (no email)
Comment 7 2005-07-05 11:26:49 PDT
Comment on attachment 2783 [details] fixes mjs's concerns ggaren, can I get a log message, or a reason? This patch builds for me just fine. I'm using gcc 4.0
Eric Seidel (no email)
Comment 8 2005-07-05 11:38:45 PDT
The build failure was only on 3.3 (which Apple internal is the only one left using).
Geoffrey Garen
Comment 9 2005-07-05 13:38:58 PDT
Created attachment 2821 [details] patch that builds w/gcc 3.3 This version of the patch builds successfully w/gcc 3.3
Maciej Stachowiak
Comment 10 2005-07-05 18:58:46 PDT
Comment on attachment 2821 [details] patch that builds w/gcc 3.3 r=me
Note You need to log in before you can comment on or make changes to this bug.