Bug 38255 – Web Inspector: REGRESSION: Disabled style properties are absent in Styles sidebar after WebInspector is re-opened

• Status: RESOLVED
• Resolution: FIXED
• Component: Web Inspector (Deprecated)

[Alexander Pavlov (apavlov)]

1. Disable a style property in Web Inspector
2. Close and re-open Web Inspector

The disabled style property is missing in the Styles sidebar (rather than rendered disabled).

[Alexander Pavlov (apavlov)]

Created attachment 54567 [details]
[PATCH] Suggested solution

[Pavel Feldman]

Comment on attachment 54567 [details]
[PATCH] Suggested solution

Clearing cq+ since I want to doublecheck something.

[Pavel Feldman]

Comment on attachment 54567 [details]
[PATCH] Suggested solution

A couple of style nits so that InspectorDOMAgent was inline with InspectorController.

[Pavel Feldman]

Comment on attachment 54567 [details]
[PATCH] Suggested solution

Oops, lost the comments with the new inline feature.

WebCore/inspector/InspectorController.cpp:424
 +  void InspectorController::updateDOMAgent()
I'd suggest this to be a domAgent lazy getter.

WebCore/inspector/InspectorController.cpp:439
 +      updateDOMAgent();
Now that dom agent lives longer, this should be domAgent()->setFrontend(m_frontend) instead of constructor with parameter.

and you should simply delegate disconnectFrontend event to the dom agent from the corresponding InspectorController method.

[Alexander Pavlov (apavlov)]

Created attachment 54797 [details]
[PATCH] Factored out the style-related storage

[WebKit Review Bot]

Attachment 54797 [details] did not pass style-queue:

Failed to run "['WebKitTools/Scripts/check-webkit-style', '--no-squash']" exit_code: 1
WebCore/inspector/InspectorDOMAgent.cpp:79:  Use 0 instead of NULL.  [readability/null] [5]
WebCore/inspector/InspectorController.cpp:59:  Alphabetical sorting problem.  [build/include_order] [4]
WebCore/inspector/InspectorCSSStore.h:38:  Code inside a namespace should not be indented.  [whitespace/indent] [4]
Total errors found: 3 in 11 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[Early Warning System Bot]

Attachment 54797 [details] did not build on qt:
Build output: http://webkit-commit-queue.appspot.com/results/1841227

[Alexander Pavlov (apavlov)]

Created attachment 54799 [details]
[PATCH] Style fixed, change description augmented

[Early Warning System Bot]

Attachment 54799 [details] did not build on qt:
Build output: http://webkit-commit-queue.appspot.com/results/1938019

[Alexander Pavlov (apavlov)]

Created attachment 54800 [details]
[PATCH] Added lost WebCore.pro change

[Yury Semikhatsky]

Comment on attachment 54800 [details]
[PATCH] Added lost WebCore.pro change

WebCore/inspector/InspectorCSSStore.cpp:45
 +      reset();
Is it necessary?

WebCore/inspector/InspectorCSSStore.h:44
 +  typedef std::pair<String, String> PropertyValueAndPriority;
Consider moving these declarations into the struct below and impporting them with "using"

[Alexander Pavlov (apavlov)]

(In reply to comment #11)
> (From update of attachment 54800 [details])
> WebCore/inspector/InspectorCSSStore.cpp:45
>  +      reset();
> Is it necessary?

Removed

> WebCore/inspector/InspectorCSSStore.h:44
>  +  typedef std::pair<String, String> PropertyValueAndPriority;
> Consider moving these declarations into the struct below and impporting them
> with "using"

As discovered, this is not feasible

[Pavel Feldman]

Comment on attachment 54800 [details]
[PATCH] Added lost WebCore.pro change

I thought we agreed not to change the InspectorDOMAgent lifetime.

[Alexander Pavlov (apavlov)]

Created attachment 54806 [details]
[PATCH] Reverted the lifespan of InspectorDOMAgent

[Eric Seidel (no email)]

Comment on attachment 54567 [details]
[PATCH] Suggested solution

Cleared Yury Semikhatsky's review+ from obsolete attachment 54567 [details] so that this bug does not appear in http://webkit.org/pending-commit.

[Alexander Pavlov (apavlov)]

Committing to http://svn.webkit.org/repository/webkit/trunk ...
        M       WebCore/ChangeLog
        M       WebCore/GNUmakefile.am
        M       WebCore/WebCore.gypi
        M       WebCore/WebCore.pro
        M       WebCore/WebCore.vcproj/WebCore.vcproj
        M       WebCore/WebCore.xcodeproj/project.pbxproj
        A       WebCore/inspector/InspectorCSSStore.cpp
        A       WebCore/inspector/InspectorCSSStore.h
        M       WebCore/inspector/InspectorController.cpp
        M       WebCore/inspector/InspectorController.h
        M       WebCore/inspector/InspectorDOMAgent.cpp
        M       WebCore/inspector/InspectorDOMAgent.h
Committed r58748