Bug 38254 – Regression on fast/text/international/khmer-selection.html

• Status: UNCONFIRMED
• Component: WebCore Misc.

[Marcus Bulach]

Reverts 58340 (https://bugs.webkit.org/show_bug.cgi?id=38158) due to regression on fast/text/international/khmer-selection.html

[Marcus Bulach]

Created attachment 54548 [details]
Patch

[WebKit Review Bot]

Attachment 54548 [details] did not pass style-queue:

Failed to run "['WebKitTools/Scripts/check-webkit-style', '--no-squash']" exit_code: 1
WebCore/platform/graphics/chromium/HarfbuzzSkia.cpp:142:  Use 0 instead of NULL.  [readability/null] [5]
Total errors found: 1 in 6 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[Jeremy Orlow]

Comment on attachment 54548 [details]
Patch

r=me

Leave this bug open after you commit to track the fact that this has been reverted.

[WebKit Commit Bot]

Comment on attachment 54548 [details]
Patch

Clearing flags on attachment: 54548

Committed r58404: <http://trac.webkit.org/changeset/58404>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.

[James Robinson]

Reverting a patch is fine, but when you do please reopen the original bug or at least CC the original patch author.  I didn't know this was reverted until I saw that the same errors were showing up.

[James Robinson]

Ah, you did CC me.  However the bugzilla emails never mentioned reverting anything.  Please do reopen the original bug when reverting a patch in the future.  Do you happen to remember what the failures were or what platforms they occurred on?

[Jeremy Orlow]

Sorry...this got mixed up with a lot of other failures those days.  I think I was going to land by hand and then changed my mind to commit bot forgetting that it needed to stay open.  I thought I documented somewhere why this was reverted, but now I can't find it, and I can't remember.  I guess maybe commit again while giving the gardener a heads up?  Sorry.

[Jeremy Orlow]

Re-opening to track.

[Marcus Bulach]

Sorry James, I should've reopened the original bug and added more info here, my bad..

IIRC, the problem was linux only:

http://test-results.appspot.com/dashboards/flakiness_dashboard.html#showExpectations=true&tests=khmer-selection.html