WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
Bug 38247
Unnecessary PrintContext::end() calls
https://bugs.webkit.org/show_bug.cgi?id=38247
Summary
Unnecessary PrintContext::end() calls
Shinichiro Hamaji
Reported
2010-04-28 01:10:36 PDT
With
http://trac.webkit.org/changeset/58386
, now PrintContext calls end() in its destructor. Let's remove unnecessary end() calls. I won't modify port specific code for now. I don't know how to check Qt and GTK printing. Chromium is using PrintContext in different way and it seems we need some refactoring works.
Attachments
Patch v1
(1.82 KB, patch)
2010-04-28 01:12 PDT
,
Shinichiro Hamaji
darin
: review+
Details
Formatted Diff
Diff
View All
Add attachment
proposed patch, testcase, etc.
Shinichiro Hamaji
Comment 1
2010-04-28 01:12:00 PDT
Created
attachment 54535
[details]
Patch v1
Shinichiro Hamaji
Comment 2
2010-04-30 02:14:44 PDT
Committed
r58566
: <
http://trac.webkit.org/changeset/58566
>
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug