Bug 38243 - Don't run transitions to/from 'auto' values
Summary: Don't run transitions to/from 'auto' values
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Layout and Rendering (show other bugs)
Version: 528+ (Nightly build)
Hardware: All OS X 10.5
: P2 Normal
Assignee: Simon Fraser (smfr)
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2010-04-27 22:52 PDT by Simon Fraser (smfr)
Modified: 2016-05-02 20:39 PDT (History)
6 users (show)

See Also:


Attachments
Patch (8.62 KB, patch)
2016-05-02 18:43 PDT, Simon Fraser (smfr)
dino: review+
buildbot: commit-queue-
Details | Formatted Diff | Diff
Archive of layout-test-results from ews101 for mac-yosemite (1.21 MB, application/zip)
2016-05-02 19:29 PDT, Build Bot
no flags Details
Archive of layout-test-results from ews112 for mac-yosemite (1.41 MB, application/zip)
2016-05-02 19:41 PDT, Build Bot
no flags Details

Note You need to log in before you can comment on or make changes to this bug.
Description Simon Fraser (smfr) 2010-04-27 22:52:11 PDT
If a Length is changing to or from an 'auto' value, we treat the auto value as zero, and so do a stupid animation.

We should just avoid running such animations.
Comment 1 Simon Fraser (smfr) 2010-12-03 15:23:43 PST
I tried this, but the problem is that transitions of 'left' on position: relative elements are fairly common, and the initial value for 'left' is 'auto'.
Comment 2 Simon Fraser (smfr) 2011-02-24 10:59:33 PST
See also bug 16020.
Comment 3 Simon Fraser (smfr) 2016-05-02 18:38:06 PDT
rdar://problem/20904225
Comment 4 Simon Fraser (smfr) 2016-05-02 18:43:20 PDT
Created attachment 277958 [details]
Patch
Comment 5 Build Bot 2016-05-02 19:29:32 PDT
Comment on attachment 277958 [details]
Patch

Attachment 277958 [details] did not pass mac-ews (mac):
Output: http://webkit-queues.webkit.org/results/1258680

New failing tests:
transitions/default-timing-function.html
Comment 6 Build Bot 2016-05-02 19:29:36 PDT
Created attachment 277962 [details]
Archive of layout-test-results from ews101 for mac-yosemite

The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: ews101  Port: mac-yosemite  Platform: Mac OS X 10.10.5
Comment 7 Build Bot 2016-05-02 19:41:51 PDT
Comment on attachment 277958 [details]
Patch

Attachment 277958 [details] did not pass mac-debug-ews (mac):
Output: http://webkit-queues.webkit.org/results/1258695

New failing tests:
transitions/default-timing-function.html
Comment 8 Build Bot 2016-05-02 19:41:55 PDT
Created attachment 277963 [details]
Archive of layout-test-results from ews112 for mac-yosemite

The attached test failures were seen while running run-webkit-tests on the mac-debug-ews.
Bot: ews112  Port: mac-yosemite  Platform: Mac OS X 10.10.5
Comment 9 Simon Fraser (smfr) 2016-05-02 20:39:48 PDT
http://trac.webkit.org/changeset/200360