Bug 38235 – Remove the unnecessary texImage2D function with Image as input in GraphicsContext3D

• Status: RESOLVED
• Resolution: FIXED
• Component: WebGL

[Zhenyao Mo]

extractImageData should happen in WebGLRenderingContext so we can track format/internalformat/etc. for conformance.

[Zhenyao Mo]

Created attachment 54503 [details]
patch

[Kenneth Russell]

Comment on attachment 54503 [details]
patch

Thanks for fixing this. Overall it looks good.

Could you add a helper texImage2D/texSubImage2D taking an Image* and refactor the versions taking HTMLCanvasElement, HTMLImageElement and HTMLVideoElement in terms of it to share more code?

Also, could you name the new routines tex{Sub}Image2DBase or tex{Sub}Image2DImpl? Changing the beginning of the method name is confusing.

[Zhenyao Mo]

Created attachment 54588 [details]
revised patch : responding to Ken Russell's review

[Kenneth Russell]

Comment on attachment 54588 [details]
revised patch : responding to Ken Russell's review

Please just use overloaded methods for texImage2DImage and texSubImage2DImage -- i.e., drop the "Image" suffix. The "Base" version is fine. Thanks.

[Zhenyao Mo]

Created attachment 54593 [details]
revised patch: remove the -image postfix

[Kenneth Russell]

Comment on attachment 54593 [details]
revised patch: remove the -image postfix

Thanks, this is a nice cleanup. Looks good to me.

[Dimitri Glazkov (Google)]

Comment on attachment 54593 [details]
revised patch: remove the -image postfix

rs=me.

[WebKit Commit Bot]

Comment on attachment 54593 [details]
revised patch: remove the -image postfix

Clearing flags on attachment: 54593

Committed r58481: <http://trac.webkit.org/changeset/58481>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.