Bug 38227 – [Chromium] Filter out URLs with a file scheme from text/uri-list when dragging.

• Status: RESOLVED
• Resolution: FIXED
• Component: New Bugs

[Daniel Cheng]

Original issue at https://bugs.webkit.org/show_bug.cgi?id=25882, which fixed duplicate file paths appearing in text/uri-list on a file drop.

This issue covers removing the remaining file:// URL from event.dataTransfer on a drop.

[Daniel Cheng]

Created attachment 54468 [details]
Filter file:// URLs from event.dataTransfer.getData

[Daniel Cheng]

Created attachment 54470 [details]
Filter file:// URLs from event.dataTransfer.getData

Fix incorrect permissions on WebCore/ChangeLog

[Jian Li]

Comment on attachment 54470 [details]
Filter file:// URLs from event.dataTransfer.getData

WebCore/ChangeLog:5
 +          [Chromium] Filter out URLs with file:// scheme from text/uri-list when dragging.
Can you update the bug title in order to be consistent with the line above. Also, I think you could simply say "file scheme".

WebCore/platform/chromium/ClipboardChromium.cpp:170
 +                  if (protocolIs(uri, "file"))
Could you please add a comment for doing this?

WebCore/platform/chromium/ClipboardChromium.cpp:185
 +          if (!m_dataObject->url.isEmpty() && !m_dataObject->url.isLocalFile()) {
ditto.

WebCore/platform/chromium/ClipboardChromium.cpp:321
 +      if (m_dataObject->url.isValid() && !m_dataObject->url.isLocalFile()) {
ditto.

[Daniel Cheng]

Created attachment 54486 [details]
Filter file URLs from event.dataTransfer.getData

[Jian Li]

Comment on attachment 54486 [details]
Filter file URLs from event.dataTransfer.getData

r=me

[WebKit Commit Bot]

Comment on attachment 54486 [details]
Filter file URLs from event.dataTransfer.getData

Clearing flags on attachment: 54486

Committed r58378: <http://trac.webkit.org/changeset/58378>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.