Bug 3822 - GW: Add necessary forwarding headers
Summary: GW: Add necessary forwarding headers
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 420+
Hardware: Mac OS X 10.4
: P4 Enhancement
Assignee: Eric Seidel (no email)
URL:
Keywords:
Depends on:
Blocks: 3250
  Show dependency tree / graph
 
Reported: 2005-07-02 19:28 PDT by Eric Seidel (no email)
Modified: 2005-07-05 01:32 PDT (History)
0 users

See Also:

Attachments
necessary forwarding headers, as described in the bug. (309 bytes, application/x-gzip)
2005-07-02 19:28 PDT, Eric Seidel (no email) 		mjs: review-
Details
new patch (as a patch now) w/o values.h (936 bytes, patch)
2005-07-03 15:16 PDT, Eric Seidel (no email) 		mjs: review+
Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Eric Seidel (no email) 2005-07-02 19:28:05 PDT 
These additional forwarding headers are required to support compiling other products against KWQ:

kinstance.h      - #import "KWQKInstance.h"
qdir.h              - empty
qglobal.h         - empty
values.h           - empty
kio/netaccess.h - empty
kjs/scope_chain.h - #import <JavaScriptCore/scope_chain.h>
Comment 1 Eric Seidel (no email) 2005-07-02 19:28:40 PDT 
Created attachment 2760 [details]
necessary forwarding headers, as described in the bug.
Comment 2 Maciej Stachowiak 2005-07-03 03:05:30 PDT 
I suggest not putting in values.h since we don't usually use the empty file hack for system headers, just 
for Qt/KDE headers that we lack. It's also better to use the constants from limits.h instead.
Comment 3 Eric Seidel (no email) 2005-07-03 14:21:59 PDT 
It turns out that they include values.h for "DBL_MAX" which is found in "float.h" on our system.  I'll #ifdef 
the include.
Comment 4 Eric Seidel (no email) 2005-07-03 14:25:34 PDT 
It turns out that they include values.h for "DBL_MAX" which is found in "float.h" on our system.  I'll #ifdef 
the include.
Comment 5 Eric Seidel (no email) 2005-07-03 15:13:57 PDT 
Actually float.h exists on linux, so we've changed the source to use that instead of values.h
Comment 6 Eric Seidel (no email) 2005-07-03 15:16:57 PDT 
Created attachment 2777 [details]
new patch (as a patch now) w/o values.h